fix(robot-server): mutable configs for attached #13696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When something hits /settings/pipettes, we load known mutable configuration overrides. So if you don't have any for the attached pipettes, we don't return anything. The thing is, what we actually want is to return all of the mutable configurations, with overrides applied. So now we do. Closes RET-1376
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.0.1 #13696 +/- ##
=======================================================
- Coverage 71.27% 71.27% -0.01%
=======================================================
Files 2427 2427
Lines 68280 68294 +14
Branches 7998 7999 +1
=======================================================
+ Hits 48668 48675 +7
- Misses 17731 17738 +7
Partials 1881 1881
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Laura-Danielle
approved these changes
Oct 3, 2023
| return _pipette_settings_from_mutable_configs(mutable_configs) | ||
|
|
||
|
|
||
| def _pipette_settings_from_pipette_dict( |
There was a problem hiding this comment.
could we call this something more like _pipette_settings_from_pipette_default and/or _pipette_settings_from_default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When something hits /settings/pipettes, we load known mutable configuration overrides. So if you don't have any for the attached pipettes, we don't return anything.
The thing is, what we actually want is to return all of the mutable configurations, with overrides applied. So now we do.
Closes RET-1376
Testing
On an OT-2, attach a pipette that doesn't have overrides and
GET /settings/pipettes(or view the pipette settings in the opentrons app).