-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-designer, step-generation, shared-data): 96-channel tip adapter + well selection support #13637
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13637 +/- ##
=======================================
Coverage 70.76% 70.77%
=======================================
Files 2488 2490 +2
Lines 69837 69920 +83
Branches 8473 8498 +25
=======================================
+ Hits 49419 49483 +64
+ Misses 18417 18414 -3
- Partials 2001 2023 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -16,7 +16,7 @@ export const determineMultiChannelSupport = ( | |||
// allow multichannel pipette options only if | |||
// all 8 channels fit into the first column correctly | |||
const multiChannelTipsFirstColumn = | |||
def !== null ? getWellNamePerMultiTip(def, 'A1') : null | |||
def !== null ? getWellNamePerMultiTip(def, 'A1', 8) : null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is for labware creator, i defaulted to only having the 8-channel since it doesn't support creating labware for a 96-channel yet.
b3e972c
to
839ccb2
Compare
fc1e4c8
to
256dc5d
Compare
a43ae5f
to
d3b912f
Compare
export function missingAdapter(): CommandCreatorError { | ||
return { | ||
type: 'MISSING_96_CHANNEL_TIPRACK_ADAPTER', | ||
message: 'A 96-channel cannot pick up tips fully without an adapter', | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: this will be wired up to replaceTip
in a follow up PR. Since we need to have knowledge of the current tiprackId
, I would need to grab that data from higher up and extend the replaceTip
args to include it. https://opentrons.atlassian.net/browse/RAUT-798
52307e2
to
7912dcb
Compare
protocol-designer/src/components/DeckSetup/LabwareOverlays/SlotControls.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gonna keep throwing these comments in batches so you can see them roll in!
protocol-designer/src/components/LabwareSelectionModal/LabwareSelectionModal.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/LabwareSelectionModal/LabwareSelectionModal.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/LabwareSelectionModal/LabwareSelectionModal.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/LabwareSelectionModal/__tests__/LabwareSelectionModal.test.tsx
Outdated
Show resolved
Hide resolved
const wellsFor96WellPlate = [ | ||
'A1', | ||
'B1', | ||
'C1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably have a function do this in a nested for loop or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code reviewed together, approved pending the comments i left
07be0f5
to
d4feaf8
Compare
d4feaf8
to
5a01be9
Compare
closes RAUT-678 RAUT-679 RAUT-697 RAUT-755
this pr is now unblocked ✨
Overview
This adds support for 2 main things for PD 96-channel:
Sorry this ended up doing a lot in 1 PR!
Test Plan
For tiprack adapter:
For 96-channel well selection:
Changelog
createContainer
thunk to include an optionaladapterUnderLabwareURI
oradapterId
in order to allow for duplicating the labware with the adapter underneath it.getWellNamePerMultiTip
and affecting utils to have knowledge of if the pipette has 96-channelsorderedWells
out of step-generation and into shared-data and created aget96Channel384WellPlateWells
util that grabs the arrays of wells the 96-channel can aspirate from in a 384 well plate)missingAdapter()
error creator to be plugged in for a follow up PRReview requests
see test plan
Risk assessment
low-ish, this changes a bunch of logic