another fix to draggableStepItems

Opentrons · Feb 16, 2024 · c5861b3 · c5861b3
1 parent 2bd2c09
commit c5861b3
Showing 1 changed file with 13 additions and 16 deletions.
diff --git a/protocol-designer/src/components/steplist/DraggableStepItems.tsx b/protocol-designer/src/components/steplist/DraggableStepItems.tsx
@@ -108,22 +108,19 @@ export const DraggableStepItems = (
   const findStepIndex = (stepId: StepIdType): number =>
     stepIds.findIndex(id => stepId === id)
 
-  const moveStep = React.useCallback(
-    (stepId: StepIdType, targetIndex: number): void => {
-      const currentIndex = findStepIndex(stepId)
-      const currentRemoved = [
-        ...stepIds.slice(0, currentIndex),
-        ...stepIds.slice(currentIndex + 1, stepIds.length),
-      ]
-      const currentReinserted = [
-        ...currentRemoved.slice(0, targetIndex),
-        stepId,
-        ...currentRemoved.slice(targetIndex, currentRemoved.length),
-      ]
-      setStepIds(currentReinserted)
-    },
-    [stepIds, findStepIndex]
-  )
+  const moveStep = (stepId: StepIdType, targetIndex: number): void => {
+    const currentIndex = findStepIndex(stepId)
+    const currentRemoved = [
+      ...stepIds.slice(0, currentIndex),
+      ...stepIds.slice(currentIndex + 1, stepIds.length),
+    ]
+    const currentReinserted = [
+      ...currentRemoved.slice(0, targetIndex),
+      stepId,
+      ...currentRemoved.slice(targetIndex, currentRemoved.length),
+    ]
+    setStepIds(currentReinserted)
+  }
 
   const currentIds = isOver ? stepIds : orderedStepIds