fix: make delete endpoint backwards compatible

Opentrons · Feb 20, 2024 · 8d6dccd · 8d6dccd
1 parent c838c18
commit 8d6dccd
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/app/src/organisms/RobotSettingsCalibration/CalibrationDetails/OverflowMenu.tsx b/app/src/organisms/RobotSettingsCalibration/CalibrationDetails/OverflowMenu.tsx
@@ -160,7 +160,7 @@ export function OverflowMenu({
       if (applicableTipLengthCal == null) return
       params = {
         calType,
-        tiprack_hash: applicableTipLengthCal.tiprack,
+        tiprack_uri: applicableTipLengthCal.uri,
         pipette_id: applicableTipLengthCal.pipette,
       }
     }

diff --git a/...src/organisms/RobotSettingsCalibration/CalibrationDetails/__tests__/OverflowMenu.test.tsx b/...src/organisms/RobotSettingsCalibration/CalibrationDetails/__tests__/OverflowMenu.test.tsx
@@ -261,7 +261,7 @@ describe('OverflowMenu', () => {
     }
     const expectedCallParams = {
       calType: 'tipLength',
-      tiprack_hash: mockTipLengthCalibrationResponse.tiprack,
+      tiprack_uri: mockTipLengthCalibrationResponse.uri,
       pipette_id: mockTipLengthCalibrationResponse.pipette,
     }
     const [{ getByText, getByLabelText }] = render(props)

diff --git a/robot-server/robot_server/service/tip_length/router.py b/robot-server/robot_server/service/tip_length/router.py
@@ -85,7 +85,10 @@ async def get_all_tip_length_calibrations(
     responses={status.HTTP_404_NOT_FOUND: {"model": ErrorBody}},
 )
 async def delete_specific_tip_length_calibration(
-    tiprack_uri: str, pipette_id: str, _: API = Depends(get_ot2_hardware)
+    pipette_id: str,
+    tiprack_hash: Optional[str] = None,
+    tiprack_uri: Optional[str] = None,
+    _: API = Depends(get_ot2_hardware),
 ):
     try:
         tip_length.delete_tip_length_calibration(