fix ts errors

Opentrons · May 15, 2024 · 7e5759d · 7e5759d
1 parent f798a95
commit 7e5759d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/app/src/organisms/QuickTransferFlow/SummaryAndSettings.tsx b/app/src/organisms/QuickTransferFlow/SummaryAndSettings.tsx
@@ -37,17 +37,13 @@ export function SummaryAndSettings(
   const [selectedCategory, setSelectedCategory] = React.useState<string>(
     'overview'
   )
-  // if any value from the wizard flow hasn't been set, return null
-  // this should never happen but allows us to strictly type summary state
-  // @ts-expect-error figure out how to make this type non-null
+  // @ts-expect-error TODO figure out how to make this type non-null as we know
+  // none of these values will be undefined
   const initialSummaryState = getInitialSummaryState(wizardFlowState)
   const [state] = React.useReducer(
     quickTransferSummaryReducer,
     initialSummaryState
   )
-  if (Object.values(wizardFlowState).some(value => value == null)) {
-    return null
-  }
 
   return (
     <Flex>

diff --git a/app/src/organisms/QuickTransferFlow/types.ts b/app/src/organisms/QuickTransferFlow/types.ts
@@ -1,7 +1,6 @@
 import type { Mount } from '@opentrons/api-client'
 import type { LabwareDefinition2, PipetteV2Specs } from '@opentrons/shared-data'
 import type { ACTIONS, CONSOLIDATE, DISTRIBUTE, TRANSFER } from './constants'
-import type { ChangeTipOptions } from '@opentrons/step-generation'
 
 export interface QuickTransferWizardState {
   pipette?: PipetteV2Specs
@@ -15,6 +14,12 @@ export interface QuickTransferWizardState {
   volume?: number
 }
 export type PathOption = 'single' | 'multiAspirate' | 'multiDispense'
+export type ChangeTipOptions =
+  | 'always'
+  | 'once'
+  | 'never'
+  | 'perDest'
+  | 'perSource'
 
 export interface QuickTransferSummaryState {
   pipette: PipetteV2Specs