feat(app, api-client): add optional runTimeParameterValues when cloni…

…ng run (#14787) closes AUTH-257
Opentrons · Apr 3, 2024 · 6ccb243 · 6ccb243
1 parent 2397044
commit 6ccb243
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 8 deletions.
diff --git a/api-client/src/runs/createRun.ts b/api-client/src/runs/createRun.ts
@@ -5,13 +5,13 @@ import type { HostConfig } from '../types'
 import type {
   Run,
   LabwareOffsetCreateData,
-  RuntimeParameterCreateData,
+  RunTimeParameterCreateData,
 } from './types'
 
 export interface CreateRunData {
   protocolId?: string
   labwareOffsets?: LabwareOffsetCreateData[]
-  runTimeParameterValues?: RuntimeParameterCreateData
+  runTimeParameterValues?: RunTimeParameterCreateData
 }
 
 export function createRun(

diff --git a/api-client/src/runs/types.ts b/api-client/src/runs/types.ts
@@ -47,6 +47,7 @@ export interface LegacyGoodRunData {
   modules: LoadedModule[]
   protocolId?: string
   labwareOffsets?: LabwareOffset[]
+  runTimeParameterValues?: RunTimeParameterCreateData
 }
 
 export interface KnownGoodRunData extends LegacyGoodRunData {
@@ -125,7 +126,7 @@ export interface LabwareOffsetCreateData {
   vector: VectorOffset
 }
 
-export interface RuntimeParameterCreateData {
+export interface RunTimeParameterCreateData {
   [key: string]: string | boolean | number
 }
 

diff --git a/app/src/organisms/ChooseProtocolSlideout/index.tsx b/app/src/organisms/ChooseProtocolSlideout/index.tsx
@@ -47,6 +47,7 @@ import { useCreateRunFromProtocol } from '../ChooseRobotToRunProtocolSlideout/us
 import { ApplyHistoricOffsets } from '../ApplyHistoricOffsets'
 import { useOffsetCandidatesForAnalysis } from '../ApplyHistoricOffsets/hooks/useOffsetCandidatesForAnalysis'
 import { getAnalysisStatus } from '../ProtocolsLanding/utils'
+import type { RunTimeParameterCreateData } from '@opentrons/api-client'
 import type { RunTimeParameter } from '@opentrons/shared-data'
 import type { Robot } from '../../redux/discovery/types'
 import type { StoredProtocolData } from '../../redux/protocol-storage'
@@ -161,7 +162,7 @@ export function ChooseProtocolSlideoutComponent(
           definitionUri,
         }))
       : [],
-    runTimeParametersOverrides.reduce(
+    runTimeParametersOverrides.reduce<RunTimeParameterCreateData>(
       (acc, param) =>
         param.value !== param.default
           ? { ...acc, [param.variableName]: param.value }

diff --git a/app/src/organisms/ChooseRobotToRunProtocolSlideout/useCreateRunFromProtocol.ts b/app/src/organisms/ChooseRobotToRunProtocolSlideout/useCreateRunFromProtocol.ts
@@ -14,7 +14,7 @@ import type {
   HostConfig,
   LabwareOffsetCreateData,
   Protocol,
-  RuntimeParameterCreateData,
+  RunTimeParameterCreateData,
 } from '@opentrons/api-client'
 import type { UseCreateRunMutationOptions } from '@opentrons/react-api-client/src/runs/useCreateRunMutation'
 import type { CreateProtocolVariables } from '@opentrons/react-api-client/src/protocols/useCreateProtocolMutation'
@@ -37,7 +37,7 @@ export function useCreateRunFromProtocol(
   options: UseCreateRunMutationOptions,
   hostOverride?: HostConfig | null,
   labwareOffsets?: LabwareOffsetCreateData[],
-  runTimeParameterValues?: RuntimeParameterCreateData
+  runTimeParameterValues?: RunTimeParameterCreateData
 ): UseCreateRun {
   const contextHost = useHost()
   const host =

diff --git a/app/src/organisms/ProtocolUpload/hooks/__tests__/useCloneRun.test.tsx b/app/src/organisms/ProtocolUpload/hooks/__tests__/useCloneRun.test.tsx
@@ -30,6 +30,7 @@ describe('useCloneRun hook', () => {
             id: RUN_ID,
             protocolId: 'protocolId',
             labwareOffsets: 'someOffset',
+            runTimeParameterValues: 'someRtp',
           },
         },
       } as any)
@@ -60,6 +61,7 @@ describe('useCloneRun hook', () => {
     expect(mockCreateRun).toHaveBeenCalledWith({
       protocolId: 'protocolId',
       labwareOffsets: 'someOffset',
+      runTimeParameterValues: 'someRtp',
     })
   })
 })
diff --git a/app/src/organisms/ProtocolUpload/hooks/useCloneRun.ts b/app/src/organisms/ProtocolUpload/hooks/useCloneRun.ts
@@ -30,8 +30,12 @@ export function useCloneRun(
   })
   const cloneRun = (): void => {
     if (runRecord != null) {
-      const { protocolId, labwareOffsets } = runRecord.data
-      createRun({ protocolId, labwareOffsets })
+      const {
+        protocolId,
+        labwareOffsets,
+        runTimeParameterValues,
+      } = runRecord.data
+      createRun({ protocolId, labwareOffsets, runTimeParameterValues })
     } else {
       console.info('failed to clone run record, source run record not found')
     }