proof of fix

Opentrons · Dec 4, 2023 · 6b7ef77 · 6b7ef77
1 parent 7ec66c3
commit 6b7ef77
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 9 deletions.
diff --git a/.github/workflows/components-test-build-deploy.yaml b/.github/workflows/components-test-build-deploy.yaml
@@ -164,8 +164,6 @@ jobs:
     runs-on: 'ubuntu-latest'
     needs: ['js-unit-test', 'determine-build-type']
     if: needs.determine-build-type.outputs.type == 'publish'
-    env: 
-      NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
     steps:
       - uses: 'actions/checkout@v3'
       # https://github.com/actions/checkout/issues/290
@@ -177,7 +175,6 @@ jobs:
       - uses: 'actions/setup-node@v3'
         with:
           node-version: '16'
-          registry-url: 'https://registry.npmjs.org'
       - name: 'cache yarn cache'
         uses: actions/cache@v3
         with:
@@ -203,9 +200,15 @@ jobs:
           VERSION_STRING=$(echo ${{ github.ref }} | sed 's/refs\/tags\/components@//')
           json -I -f ./components/package.json -e "this.version=\"$VERSION_STRING\""
           json -I -f ./components/package.json -e "this.dependencies['@opentrons/shared-data']=\"$VERSION_STRING\""
+          cd ./components
+      - uses: 'actions/setup-node@v3'
+        with:
+          node-version: '16'
+          registry-url: 'https://registry.npmjs.org'
       - name: 'publish to npm registry'
-        run: |
-          cd ./components && echo "//registry.npmjs.org/:_authToken=${NODE_AUTH_TOKEN}" > ./.yarnrc && yarn publish --access public
+        run: yarn publish --access public
+        env: 
+          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
 
 
 
diff --git a/.github/workflows/shared-data-test-lint-deploy.yaml b/.github/workflows/shared-data-test-lint-deploy.yaml
@@ -215,8 +215,6 @@ jobs:
     runs-on: 'ubuntu-latest'
     needs: ['js-test', 'publish-switch']
     if: needs.publish-switch.outputs.should_publish == 'true'
-    env: 
-      NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
     steps:
       - uses: 'actions/checkout@v3'
       # https://github.com/actions/checkout/issues/290
@@ -253,7 +251,13 @@ jobs:
           npm install -g json
           VERSION_STRING=$(echo ${{ github.ref }} | sed -E 's/refs\/tags\/(components|shared-data)@//')
           json -I -f ./shared-data/package.json -e "this.version=\"$VERSION_STRING\""
+          cd ./shared-data
+      - uses: 'actions/setup-node@v3'
+        with:
+          node-version: '16'
+          registry-url: 'https://registry.npmjs.org'
       - name: 'publish to npm registry'
-        run: |
-          cd ./components && echo "//registry.npmjs.org/:_authToken=${NODE_AUTH_TOKEN}" > ./.yarnrc && yarn publish --access public
+        run: yarn publish --access public
+        env: 
+          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}