standardize mocking of file-saver to avoid sterr dump

Opentrons · Feb 28, 2024 · 5f29ad3 · 5f29ad3
1 parent 5acb14d
commit 5f29ad3
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/app/src/organisms/CheckCalibration/ResultsSummary/__tests__/ResultsSummary.test.tsx b/app/src/organisms/CheckCalibration/ResultsSummary/__tests__/ResultsSummary.test.tsx
@@ -15,6 +15,7 @@ import { ResultsSummary } from '../'
 
 import type { CalibrationPanelProps } from '../../../../organisms/CalibrationPanels/types'
 
+// file-saver has circular dep, need to mock with factory to prevent error
 vi.mock('file-saver', async importOriginal => {
   const actual = await importOriginal<typeof saveAs>()
   return {

diff --git a/...src/organisms/RobotSettingsCalibration/CalibrationDetails/__tests__/OverflowMenu.test.tsx b/...src/organisms/RobotSettingsCalibration/CalibrationDetails/__tests__/OverflowMenu.test.tsx
@@ -43,7 +43,14 @@ const PIPETTE_NAME = 'pipetteName'
 const OT3_PIPETTE_NAME = OT3_PIPETTES[0]
 
 const startCalibration = vi.fn()
-vi.mock('file-saver')
+// file-saver has circular dep, need to mock with factory to prevent error
+vi.mock('file-saver', async importOriginal => {
+  const actual = await importOriginal<typeof saveAs>()
+  return {
+    ...actual,
+    saveAs: vi.fn(),
+  }
+})
 vi.mock('@opentrons/react-api-client')
 vi.mock('../../../../redux/sessions/selectors')
 vi.mock('../../../../redux/discovery')

diff --git a/app/src/organisms/RobotSettingsCalibration/__tests__/CalibrationDataDownload.test.tsx b/app/src/organisms/RobotSettingsCalibration/__tests__/CalibrationDataDownload.test.tsx
@@ -46,7 +46,14 @@ import { renderWithProviders } from '../../../__testing-utils__'
 import { useIsEstopNotDisengaged } from '../../../resources/devices/hooks/useIsEstopNotDisengaged'
 import { CalibrationDataDownload } from '../CalibrationDataDownload'
 
-vi.mock('file-saver')
+// file-saver has circular dep, need to mock with factory to prevent error
+vi.mock('file-saver', async importOriginal => {
+  const actual = await importOriginal<typeof saveAs>()
+  return {
+    ...actual,
+    saveAs: vi.fn(),
+  }
+})
 vi.mock('@opentrons/react-api-client')
 vi.mock('../../../redux/analytics')
 vi.mock('../../../organisms/Devices/hooks')