Skip to content

Commit

Permalink
fix(protocol-designer): make checked box icon ot-checkbox (#15165)
Browse files Browse the repository at this point in the history
closes RQA-2707
  • Loading branch information
jerader authored May 10, 2024
1 parent a96add8 commit 498461d
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion components/src/forms/DeprecatedCheckboxField.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export function DeprecatedCheckboxField(
props.isIndeterminate
? 'minus-box'
: props.value
? 'checkbox-marked'
? 'ot-checkbox'
: 'checkbox-blank-outline'
}
width="100%"
Expand Down
2 changes: 1 addition & 1 deletion protocol-designer/src/components/lists/TitledStepList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export function TitledStepList(props: Props): JSX.Element {
)

const multiSelectIconName = props.selected
? 'checkbox-marked'
? 'ot-checkbox'
: 'checkbox-blank-outline'

return (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,11 @@ export function EquipmentOption(props: EquipmentOptionProps): JSX.Element {
iconInfo = (
<Icon
aria-label={`EquipmentOption_${
isSelected ? 'checkbox-marked' : 'checkbox-blank-outline'
isSelected ? 'ot-checkbox' : 'checkbox-blank-outline'
}`}
color={isSelected ? COLORS.blue50 : COLORS.grey50}
size="1.5rem"
name={isSelected ? 'checkbox-marked' : 'checkbox-blank-outline'}
name={isSelected ? 'ot-checkbox' : 'checkbox-blank-outline'}
/>
)
} else if (showCheckbox && disabled) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@ describe('EquipmentOption', () => {
}
render(props)
screen.getByText('mockText')
expect(
screen.getByLabelText('EquipmentOption_checkbox-marked')
).toHaveStyle(`color: ${COLORS.blue50}`)
expect(screen.getByLabelText('EquipmentOption_ot-checkbox')).toHaveStyle(
`color: ${COLORS.blue50}`
)
expect(screen.getByLabelText('EquipmentOption_flex_mockText')).toHaveStyle(
`border: ${BORDERS.activeLineBorder}`
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ export const MultiSelectToolbar = (props: Props): JSX.Element => {
} = useConditionalConfirm(onDeleteClickAction, true)

const selectProps: ClickableIconProps = {
iconName: isAllStepsSelected ? 'checkbox-marked' : 'minus-box',
iconName: isAllStepsSelected ? 'ot-checkbox' : 'minus-box',
tooltipText: isAllStepsSelected ? 'Deselect All' : 'Select All',
onClick: confirmSelect,
}
Expand Down

0 comments on commit 498461d

Please sign in to comment.