Skip to content

Commit

Permalink
feedback and docstrings
Browse files Browse the repository at this point in the history
  • Loading branch information
mjhuff committed Feb 16, 2024
1 parent dd5f77e commit 4803bde
Showing 5 changed files with 9 additions and 14 deletions.
6 changes: 1 addition & 5 deletions app/src/molecules/BackgroundOverlay/index.tsx
Original file line number Diff line number Diff line change
@@ -12,11 +12,7 @@ const BACKGROUND_OVERLAY_STYLE = css`
position: ${POSITION_FIXED};
inset: 0;
z-index: 3;
background-color: ${COLORS.black90}${COLORS.opacity40HexCode};
@media ${RESPONSIVENESS.touchscreenMediaQuerySpecs} {
background-color: ${COLORS.black90}${COLORS.opacity60HexCode};
}
background-color: ${COLORS.black90}${COLORS.opacity60HexCode};
`

export interface BackgroundOverlayProps
4 changes: 0 additions & 4 deletions app/src/molecules/LegacyModal/LegacyModalShell.tsx
Original file line number Diff line number Diff line change
@@ -84,10 +84,6 @@ const Overlay = styled.div`
z-index: 1;
background-color: ${COLORS.black90}${COLORS.opacity40HexCode};
cursor: default;
@media ${RESPONSIVENESS.touchscreenMediaQuerySpecs} {
background-color: ${COLORS.black90}${COLORS.opacity60HexCode};
}
`
const ContentArea = styled.div<{ zIndex: string | number }>`
display: flex;
3 changes: 3 additions & 0 deletions app/src/molecules/LegacyModal/index.tsx
Original file line number Diff line number Diff line change
@@ -19,6 +19,9 @@ export interface LegacyModalProps extends StyleProps {
footer?: React.ReactNode
}

/**
* For Desktop app use only.
*/
export const LegacyModal = (props: LegacyModalProps): JSX.Element => {
const {
type = 'info',
3 changes: 3 additions & 0 deletions app/src/molecules/Modal/Modal.tsx
Original file line number Diff line number Diff line change
@@ -24,6 +24,9 @@ interface ModalProps extends StyleProps {
/** see ModalHeader component for more details */
header?: ModalHeaderBaseProps
}
/**
* For ODD use only.
*/
export function Modal(props: ModalProps): JSX.Element {
const {
modalSize = 'medium',
7 changes: 2 additions & 5 deletions components/src/modals/ModalShell.tsx
Original file line number Diff line number Diff line change
@@ -78,13 +78,10 @@ const Overlay = styled.div`
top: 0;
bottom: 0;
z-index: 1;
background-color: ${COLORS.black90}${COLORS.opacity40HexCode};
background-color: ${COLORS.black90}${COLORS.opacity60HexCode};
cursor: default;
@media ${RESPONSIVENESS.touchscreenMediaQuerySpecs} {
background-color: ${COLORS.black90}${COLORS.opacity60HexCode};
}
`

const ContentArea = styled.div<{ zIndex: string | number }>`
display: flex;
position: ${POSITION_ABSOLUTE};

0 comments on commit 4803bde

Please sign in to comment.