review cleanup

Opentrons · Apr 12, 2024 · 45c27b1 · 45c27b1
1 parent 5610f9f
commit 45c27b1
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 11 deletions.
diff --git a/api-client/src/protocols/createProtocolAnalysis.ts b/api-client/src/protocols/createProtocolAnalysis.ts
@@ -1,8 +1,8 @@
 import { POST, request } from '../request'
 
+import type { ProtocolAnalysisSummary } from '@opentrons/shared-data'
 import type { ResponsePromise } from '../request'
 import type { HostConfig } from '../types'
-import type { ProtocolAnalysisSummary } from '@opentrons/shared-data'
 import type { RunTimeParameterCreateData } from '../runs'
 
 interface CreateProtocolAnalysisData {

diff --git a/app/src/organisms/ProtocolSetupParameters/__tests__/ProtocolSetupParameters.test.tsx b/app/src/organisms/ProtocolSetupParameters/__tests__/ProtocolSetupParameters.test.tsx
@@ -70,7 +70,6 @@ describe('ProtocolSetupParameters', () => {
   })
   it('renders the other setting when boolean param is selected', () => {
     render(props)
-    screen.debug()
     expect(screen.getAllByText('On')).toHaveLength(2)
     fireEvent.click(screen.getByText('Dry Run'))
     expect(screen.getAllByText('On')).toHaveLength(3)

diff --git a/react-api-client/src/protocols/useCreateProtocolAnalysisMutation.ts b/react-api-client/src/protocols/useCreateProtocolAnalysisMutation.ts
@@ -1,18 +1,18 @@
-import { useMutation, useQueryClient } from 'react-query'
-import type {
-  UseMutationResult,
-  UseMutationOptions,
-  UseMutateFunction,
-} from 'react-query'
 import { createProtocolAnalysis } from '@opentrons/api-client'
+import { useMutation, useQueryClient } from 'react-query'
 import { useHost } from '../api'
-import type { AxiosError } from 'axios'
 import type {
   ErrorResponse,
   HostConfig,
   RunTimeParameterCreateData,
 } from '@opentrons/api-client'
 import type { ProtocolAnalysisSummary } from '@opentrons/shared-data'
+import type { AxiosError } from 'axios'
+import type {
+  UseMutationResult,
+  UseMutationOptions,
+  UseMutateFunction,
+} from 'react-query'
 
 export interface CreateProtocolAnalysisVariables {
   protocolKey: string
@@ -69,12 +69,12 @@ export function useCreateProtocolAnalysisMutation(
                 response.data
               )
             )
-            .catch(e => {
+            .catch((e: Error) => {
               throw e
             })
           return response.data
         })
-        .catch(e => {
+        .catch((e: Error) => {
           throw e
         }),
     options