-
Notifications
You must be signed in to change notification settings - Fork 179
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor(labware-library): remove python test protocol affordances fr…
…om labware-creator The utility of the python test protocol generated from the labware creator has worn-down and been replaced by other more helpful trouble shooting tools. Return the labware json file by itself instead of a zip Closes RAUT-198
- Loading branch information
Showing
13 changed files
with
23 additions
and
667 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
129 changes: 0 additions & 129 deletions
129
labware-library/src/labware-creator/components/getPipetteOptions.tsx
This file was deleted.
Oops, something went wrong.
105 changes: 5 additions & 100 deletions
105
labware-library/src/labware-creator/components/sections/Export.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,117 +1,22 @@ | ||
| import cx from 'classnames' | ||
| import * as React from 'react' | ||
| import { useFormikContext } from 'formik' | ||
| import { PrimaryBtn } from '@opentrons/components' | ||
| import { reportEvent } from '../../../analytics' | ||
| import { FormStatus, LabwareFields } from '../../fields' | ||
| import { isEveryFieldHidden } from '../../utils' | ||
| import { getPipetteNameOptions } from '../getPipetteOptions' | ||
| import { FormAlerts } from '../alerts/FormAlerts' | ||
| import { Dropdown } from '../Dropdown' | ||
| import { LinkOut } from '../LinkOut' | ||
| import { SectionBody } from './SectionBody' | ||
| import { PrimaryButton } from '@opentrons/components' | ||
| import styles from '../../styles.css' | ||
| import { determineMultiChannelSupport } from '../../utils/determineMultiChannelSupport' | ||
|
|
||
| const LABWARE_PDF_URL = | ||
| 'https://insights.opentrons.com/hubfs/Products/Consumables%20and%20Reagents/labwareDefinition_testGuide.pdf' | ||
| const TIPRACK_PDF_URL = | ||
| 'https://insights.opentrons.com/hubfs/Products/Consumables%20and%20Reagents/labwareDefinition_tipRack_testGuide.pdf' | ||
|
|
||
| interface ExportProps { | ||
| onExportClick: (e: React.MouseEvent) => unknown | ||
| } | ||
|
|
||
| export const Export = (props: ExportProps): JSX.Element | null => { | ||
| const fieldList: Array<keyof LabwareFields> = ['pipetteName'] | ||
| const _context = useFormikContext<LabwareFields>() | ||
| const { values, errors, touched } = _context | ||
| const status: FormStatus = _context.status | ||
| const { defaultedDef } = status | ||
|
|
||
| const testGuideUrl = | ||
| values.labwareType === 'tipRack' ? TIPRACK_PDF_URL : LABWARE_PDF_URL | ||
| const testGuideLabel = | ||
| values.labwareType === 'tipRack' | ||
| ? 'tip rack test guide' | ||
| : 'labware test guide' | ||
|
|
||
| if (isEveryFieldHidden(fieldList, values)) { | ||
| return null | ||
| } | ||
|
|
||
| const { | ||
| disablePipetteField, | ||
| allowMultiChannel, | ||
| } = determineMultiChannelSupport(defaultedDef) | ||
|
|
||
| return ( | ||
| <SectionBody label="Labware Test Protocol" id="Export"> | ||
| <FormAlerts | ||
| values={values} | ||
| touched={touched} | ||
| errors={errors} | ||
| fieldList={fieldList} | ||
| /> | ||
|
|
||
| <div className={cx(styles.flex_row, styles.flex_row_start)}> | ||
| <div className={styles.instructions_column}> | ||
| <p> | ||
| Your file will be exported with a protocol that will help you test | ||
| and troubleshoot your labware definition on the robot. The protocol | ||
| requires a Single or 8-Channel pipette on the right mount of your | ||
| robot. | ||
| </p> | ||
| </div> | ||
| <div className={styles.pipette_field_wrapper}> | ||
| <Dropdown | ||
| disabled={disablePipetteField} | ||
| tooltip={ | ||
| disablePipetteField ? ( | ||
| <div>Add missing measurements to select a test pipette</div> | ||
| ) : undefined | ||
| } | ||
| name="pipetteName" | ||
| options={getPipetteNameOptions(allowMultiChannel)} | ||
| width="18rem" | ||
| /> | ||
| </div> | ||
| </div> | ||
| <div> | ||
| <div className={styles.export_section} id="DefinitionTest"> | ||
| <div className={cx(styles.callout, styles.export_callout)}> | ||
| <h4 className={styles.test_labware_heading}> | ||
| Please test your definition file! | ||
| </h4> | ||
|
|
||
| <p> | ||
| Use the labware test protocol contained in the downloaded file to | ||
| check the accuracy of your definition. It’s important to create | ||
| definitions that are precise and do not rely on excessive | ||
| calibration prior to each run to achieve accuracy. | ||
| </p> | ||
| <p> | ||
| Use the Tip Rack guide to troubleshoot Tip Rack definitions. Use the | ||
| Labware guide for all other labware types. | ||
| </p> | ||
| <LinkOut | ||
| onClick={() => | ||
| reportEvent({ | ||
| name: 'labwareCreatorClickTestLabware', | ||
| }) | ||
| } | ||
| href={testGuideUrl} | ||
| className={styles.test_guide_button} | ||
| > | ||
| {testGuideLabel} | ||
| </LinkOut> | ||
| </div> | ||
| <PrimaryBtn | ||
| <PrimaryButton | ||
| className={styles.export_button} | ||
| onClick={props.onExportClick} | ||
| > | ||
| EXPORT FILE | ||
| </PrimaryBtn> | ||
| </PrimaryButton> | ||
| </div> | ||
| </SectionBody> | ||
| </div> | ||
| ) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.