fix(app): fix LPC offsets not appropriately updating (#14487)

Closes RQA-2296 The staleTime property was not handled correctly by the useNotifyService notification hook. In addition to disabling notifications when using staleTime, we must also alert the HTTP hook that it is responsible for refetching HTTP data.
Opentrons · Feb 13, 2024 · 23146ba · 23146ba
1 parent 9badd57
commit 23146ba
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/app/src/resources/maintenance_runs/useNotifyCurrentMaintenanceRun.ts b/app/src/resources/maintenance_runs/useNotifyCurrentMaintenanceRun.ts
@@ -23,7 +23,11 @@ export function useNotifyCurrentMaintenanceRun(
     },
   })
 
-  const isNotifyEnabled = !isNotifyError && !options?.forceHttpPolling
+  const isNotifyEnabled =
+    !isNotifyError &&
+    !options?.forceHttpPolling &&
+    options?.staleTime !== Infinity
+
   if (!isNotifyEnabled && !refetchUsingHTTP) setRefetchUsingHTTP(true)
   const isHTTPEnabled =
     host !== null && options?.enabled !== false && refetchUsingHTTP

diff --git a/app/src/resources/runs/useNotifyAllRunsQuery.ts b/app/src/resources/runs/useNotifyAllRunsQuery.ts
@@ -26,7 +26,11 @@ export function useNotifyAllRunsQuery(
     options,
   })
 
-  const isNotifyEnabled = !isNotifyError && !options?.forceHttpPolling
+  const isNotifyEnabled =
+    !isNotifyError &&
+    !options?.forceHttpPolling &&
+    options?.staleTime !== Infinity
+
   if (!isNotifyEnabled && !refetchUsingHTTP) setRefetchUsingHTTP(true)
   const isHTTPEnabled = options?.enabled !== false && refetchUsingHTTP
 

diff --git a/app/src/resources/runs/useNotifyRunQuery.ts b/app/src/resources/runs/useNotifyRunQuery.ts
@@ -22,7 +22,11 @@ export function useNotifyRunQuery<TError = Error>(
     options: { ...options, enabled: options.enabled && runId != null },
   })
 
-  const isNotifyEnabled = !isNotifyError && !options?.forceHttpPolling
+  const isNotifyEnabled =
+    !isNotifyError &&
+    !options?.forceHttpPolling &&
+    options?.staleTime !== Infinity
+
   if (!isNotifyEnabled && !refetchUsingHTTP) setRefetchUsingHTTP(true)
   const isHTTPEnabled =
     options?.enabled !== false &&