small fixes

Opentrons · Sep 7, 2023 · 2253279 · 2253279
1 parent a71d233
commit 2253279
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 9 deletions.
diff --git a/app/src/organisms/Devices/PipetteCard/index.tsx b/app/src/organisms/Devices/PipetteCard/index.tsx
@@ -297,7 +297,7 @@ export const PipetteCard = (props: PipetteCardProps): JSX.Element => {
                     <StyledText
                       as="p"
                       css={BANNER_LINK_CSS}
-                      onClick={updatePipette()}
+                      onClick={updatePipette}
                     />
                   ),
                 }}

diff --git a/app/src/organisms/FirmwareUpdateModal/FirmwareUpdateTakeover.tsx b/app/src/organisms/FirmwareUpdateModal/FirmwareUpdateTakeover.tsx
@@ -6,12 +6,12 @@ import {
   useCurrentAllSubsystemUpdatesQuery,
   useSubsystemUpdateQuery,
 } from '@opentrons/react-api-client'
-
+import { Portal } from '../../App/portal'
 import { useIsUnboxingFlowOngoing } from '../RobotSettingsDashboard/NetworkSettings/hooks'
 import { UpdateInProgressModal } from './UpdateInProgressModal'
-
 import { UpdateNeededModal } from './UpdateNeededModal'
 import type { Subsystem } from '@opentrons/api-client'
+
 const POLL_INTERVAL_5000_MS = 5000
 
 export function FirmwareUpdateTakeover(): JSX.Element {
@@ -83,11 +83,13 @@ export function FirmwareUpdateTakeover(): JSX.Element {
         />
       ) : null}
       {externalSubsystemUpdate != null ? (
-        <UpdateInProgressModal
-          percentComplete={
-            externalsubsystemUpdateData?.data.updateProgress ?? 0
-          }
-        />
+        <Portal level="top">
+          <UpdateInProgressModal
+            percentComplete={
+              externalsubsystemUpdateData?.data.updateProgress ?? 0
+            }
+          />
+        </Portal>
       ) : null}
     </>
   )

diff --git a/app/src/organisms/GripperCard/index.tsx b/app/src/organisms/GripperCard/index.tsx
@@ -143,7 +143,7 @@ export function GripperCard({
                     <StyledText
                       as="p"
                       css={BANNER_LINK_CSS}
-                      onClick={setSubsystemToUpdate('gripper')}
+                      onClick={() => setSubsystemToUpdate('gripper')}
                     />
                   ),
                 }}