Skip to content

Commit

Permalink
feat(abr-testing): ABR protocols and Liquid Set Ups (#16728)
Browse files Browse the repository at this point in the history
<!--
Thanks for taking the time to open a Pull Request (PR)! Please make sure
you've read the "Opening Pull Requests" section of our Contributing
Guide:


https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests

GitHub provides robust markdown to format your PR. Links, diagrams,
pictures, and videos along with text formatting make it possible to
create a rich and informative PR. For more information on GitHub
markdown, see:


https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax

To ensure your code is reviewed quickly and thoroughly, please fill out
the sections below to the best of your ability!
-->

# Overview

Current ABR Protocols and Liquid Set Ups

## Test Plan and Hands on Testing

All protocols have been simulated and ran on ABR robots successfully.

## Changelog

- Protocols include helper functions to load commonly used parameters,
module/adapter/labware set ups, loading liquids, probing liquids,
measuring height of loaded liquids
- Protocols follow format and linting rules, excluding flake8 complexity
score.

## Review requests

<!--
- What do you need from reviewers to feel confident this PR is ready to
merge?
- Ask questions.
-->

## Risk assessment

- Protocols will no longer be able to be analyzed on the app, but will
work on the robot as long as the `abr-testing` folder is pushed to it.
However, protocols will still be analyzed using the abr `make simulate`
command.

---------

Co-authored-by: Seth Foster <[email protected]>
  • Loading branch information
rclarke0 and sfoster1 authored Nov 8, 2024
1 parent 5b7be2e commit 18b0eb4
Show file tree
Hide file tree
Showing 34 changed files with 7,826 additions and 162 deletions.
3 changes: 3 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ robot-server/**
shared-data/python/**
hardware-testing/**

# abr-testing don't format the json protocols
abr-testing/protocols/**

# analyses-snapshot-testing don't format the json protocols
analyses-snapshot-testing/files
# don't format the snapshots
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ lint-js-prettier:

.PHONY: lint-json
lint-json:
yarn eslint --max-warnings 0 --ext .json .
yarn eslint --ignore-pattern "abr-testing/protocols/" --max-warnings 0 --ext .json .

.PHONY: lint-css
lint-css:
Expand Down
3 changes: 2 additions & 1 deletion abr-testing/.flake8
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,5 @@ docstring-convention = google

noqa-require-code = true

# per-file-ignores =
per-file-ignores =
abr_testing/protocols/*: C901
1 change: 1 addition & 0 deletions abr-testing/Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ slack-sdk = "*"
pandas = "*"
pandas-stubs = "*"
paramiko = "*"
prettier = "*"

[dev-packages]
atomicwrites = "==1.4.1"
Expand Down
326 changes: 167 additions & 159 deletions abr-testing/Pipfile.lock

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def run(file_to_simulate: Path) -> None:

exclude = [
"__init__.py",
"shared_vars_and_funcs.py",
"helpers.py",
]
# Walk through the root directory and its subdirectories
for root, dirs, files in os.walk(root_dir):
Expand Down
1 change: 1 addition & 0 deletions abr-testing/abr_testing/protocols/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
"""protocols."""
Loading

0 comments on commit 18b0eb4

Please sign in to comment.