fix(app): open external links in browser (#14447)

external links were opening in the electron browser window instead of an external browser window closes RQA-2309
Opentrons · Feb 7, 2024 · 17963c0 · 17963c0
1 parent b8a60d6
commit 17963c0
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/app-shell/src/ui.ts b/app-shell/src/ui.ts
@@ -57,14 +57,10 @@ export function createUi(): BrowserWindow {
   mainWindow.loadURL(url, { extraHeaders: 'pragma: no-cache\n' })
 
   // open new windows (<a target="_blank" ...) in browser windows
-  mainWindow.webContents.setWindowOpenHandler(({ url, disposition }) => {
-    if (disposition === 'new-window' && url === 'about:blank') {
-      // eslint-disable-next-line no-void
-      void shell.openExternal(url)
-      return { action: 'deny' }
-    } else {
-      return { action: 'allow' }
-    }
+  mainWindow.webContents.setWindowOpenHandler(({ url }) => {
+    // eslint-disable-next-line no-void
+    void shell.openExternal(url)
+    return { action: 'deny' }
   })
 
   return mainWindow