Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(recipe): update nodejs to 22.11.0 #180

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Dec 3, 2024

Works towards EXEC-1032

Opentrons/opentrons#17010 updates Electron, which requires updating node.

This PR bumps the node recipe to 22.11.0. Related patches require backporting icu.

Testing

Flex builds (based on this branch and the monorepo branch)

  • Does building a Flex image with the linked branch succeed?
  • Does the build actually run on the Flex?

NOTE: This shouldn't be merged until the monorepo PR is tested and approved.

@mjhuff mjhuff requested a review from sfoster1 December 3, 2024 15:16
@mjhuff mjhuff force-pushed the update-node-to-22.11.0 branch 2 times, most recently from 726759a to 3a4806a Compare December 3, 2024 16:50
@mjhuff mjhuff force-pushed the update-node-to-22.11.0 branch 2 times, most recently from 2b81230 to eabaaff Compare December 3, 2024 18:22
@mjhuff mjhuff requested a review from vegano1 December 4, 2024 17:19
@mjhuff mjhuff marked this pull request as ready for review December 4, 2024 17:19
@mjhuff mjhuff force-pushed the update-node-to-22.11.0 branch from eabaaff to 797df22 Compare December 5, 2024 16:00
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks!

Copy link
Contributor

@ryanthecoder ryanthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mjhuff mjhuff merged commit 594d4cd into main Dec 5, 2024
2 of 3 checks passed
@mjhuff mjhuff deleted the update-node-to-22.11.0 branch December 5, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants