util: add --debug-cycle to help debug print #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensen-yan
force-pushed
the
add_debug_cycle
branch
from
8ea1980 to
a536721
Compare
it will enable print cycle in DPRINTF, print tick is difficult to debug, print cycle helps, DPRINTF print like: 31635: system.cpu.branchPred: [c: 95] DecoupledBPUWithFTB::tick() c: 95 means cycle, 95 = 31635 / 333, 333 is ticks for 1 cycle in 3GHz, use cpu->clockPeriod() is greater, but not all class have cpu member. Change-Id: I0ff1f3e3290842e6ba110393705c003616103924
happy-lx
approved these changes
Jan 14, 2025
shinezyy
requested changes
Jan 14, 2025
There was a problem hiding this comment.
The reason that original dprintf printing ticks instead of cycles is that not all clockedobjects are in the same clock domain.
But it is much more convenient for CPU guys to use a CPU core clock (this is the reason of this patch).
To avoid magic 333, I suggest to add a new member function "cpuCycle()" to "clockedObject".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it will enable print cycle in DPRINTF,
print tick is difficult to debug, print cycle helps, DPRINTF print like:
31635: system.cpu.branchPred: [c: 95] DecoupledBPUWithFTB::tick()
c: 95 means cycle, 95 = 31635 / 333, 333 is ticks for 1 cycle in 3GHz, use cpu->clockPeriod() is greater, but not all class have cpu member.
Change-Id: I0ff1f3e3290842e6ba110393705c003616103924