Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vglass: replace surfman/input-server with vglass #1382
vglass: replace surfman/input-server with vglass #1382
Changes from all commits
dd6c87b
a824a0c
ec2ebbb
0c66f04
8f82bbb
12213df
b4426a4
cd4cfa1
e9730dc
37df8f3
321bf90
5072717
d77f6c6
36f7bc3
f2e6def
45c54bf
e20d83b
2c85f96
9c67f4f
3bfc716
abdf92f
0081d6c
ad00c30
3487874
81d94b0
714bdec
78d7a87
bf48cc2
2370bd7
1ec4b9f
763ec4f
a4d659f
e0b801f
eb9d550
21a012c
eded591
fbe5458
401e525
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hoping that dependencies could handle this, but libpvglass depends on virtual/libivc, so we can't just make vglass depend on libvc2 and qemu depend on libivc, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that is why I ended up defining a prefered per-machine provider, which in turns comes from libpvbackendhelper/libpvdisplayhelper, aka recipe libpvglass, exporting the same public headers, OE rightfully reports one can overwrite the other if they are provided by two different recipes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like it's in the wrong commit 761aed3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is indeed.