Skip to content

Commit

Permalink
Fix wrong doxygen comments
Browse files Browse the repository at this point in the history
Add some missing "<" to trailing comments
to make sure they apply to the correct line.

Change-Id: Ib88ce925b20c5912de489ef1b62615c4b87d365c
Signed-off-by: Frank Lichtenheld <[email protected]>
Acked-by: Lev Stipakov <[email protected]>
Message-Id: <[email protected]>
URL: https://www.mail-archive.com/[email protected]/msg29897.html
Signed-off-by: Gert Doering <[email protected]>
  • Loading branch information
flichtenheld authored and cron2 committed Nov 26, 2024
1 parent d52ea24 commit 6c636f5
Show file tree
Hide file tree
Showing 5 changed files with 27 additions and 24 deletions.
24 changes: 12 additions & 12 deletions src/openvpn/options.c
Original file line number Diff line number Diff line change
Expand Up @@ -929,10 +929,10 @@ uninit_options(struct options *o)

struct pull_filter
{
#define PUF_TYPE_UNDEF 0 /** undefined filter type */
#define PUF_TYPE_ACCEPT 1 /** filter type to accept a matching option */
#define PUF_TYPE_IGNORE 2 /** filter type to ignore a matching option */
#define PUF_TYPE_REJECT 3 /** filter type to reject and trigger SIGUSR1 */
#define PUF_TYPE_UNDEF 0 /**< undefined filter type */
#define PUF_TYPE_ACCEPT 1 /**< filter type to accept a matching option */
#define PUF_TYPE_IGNORE 2 /**< filter type to ignore a matching option */
#define PUF_TYPE_REJECT 3 /**< filter type to reject and trigger SIGUSR1 */
int type;
int size;
char *pattern;
Expand Down Expand Up @@ -3846,14 +3846,14 @@ options_postprocess_mutate(struct options *o, struct env_set *es)
* Check file/directory sanity
*
*/
#ifndef ENABLE_SMALL /** Expect people using the stripped down version to know what they do */

#define CHKACC_FILE (1<<0) /** Check for a file/directory presence */
#define CHKACC_DIRPATH (1<<1) /** Check for directory presence where a file should reside */
#define CHKACC_FILEXSTWR (1<<2) /** If file exists, is it writable? */
#define CHKACC_ACPTSTDIN (1<<3) /** If filename is stdin, it's allowed and "exists" */
#define CHKACC_PRIVATE (1<<4) /** Warn if this (private) file is group/others accessible */
#define CHKACC_ACCEPT_URI (1<<5) /** If filename is a URI, no check is done unless it starts with file: */
#ifndef ENABLE_SMALL /* Expect people using the stripped down version to know what they do */

#define CHKACC_FILE (1<<0) /**< Check for a file/directory presence */
#define CHKACC_DIRPATH (1<<1) /**< Check for directory presence where a file should reside */
#define CHKACC_FILEXSTWR (1<<2) /**< If file exists, is it writable? */
#define CHKACC_ACPTSTDIN (1<<3) /**< If filename is stdin, it's allowed and "exists" */
#define CHKACC_PRIVATE (1<<4) /**< Warn if this (private) file is group/others accessible */
#define CHKACC_ACCEPT_URI (1<<5) /**< Do not check URIs, unless they start with file: */

static bool
check_file_access(const int type, const char *file, const int mode, const char *opt)
Expand Down
8 changes: 4 additions & 4 deletions src/openvpnmsica/msica_arg.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@
*/
struct msica_arg
{
struct msica_arg *next; /** Pointer to the next argument in the sequence */
TCHAR val[]; /** Zero terminated argument string */
struct msica_arg *next; /**< Pointer to the next argument in the sequence */
TCHAR val[]; /**< Zero terminated argument string */
};


Expand All @@ -47,8 +47,8 @@ struct msica_arg
*/
struct msica_arg_seq
{
struct msica_arg *head; /** Pointer to the first argument in the sequence */
struct msica_arg *tail; /** Pointer to the last argument in the sequence */
struct msica_arg *head; /**< Pointer to the first argument in the sequence */
struct msica_arg *tail; /**< Pointer to the last argument in the sequence */
};


Expand Down
9 changes: 6 additions & 3 deletions src/openvpnmsica/openvpnmsica.c
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,10 @@
* Local constants
*/

#define MSICA_ADAPTER_TICK_SIZE (16*1024) /** Amount of tick space to reserve for one TAP/TUN adapter creation/deletition. */
/** Amount of tick space to reserve for one TAP/TUN adapter creation/deletition. */
#define MSICA_ADAPTER_TICK_SIZE (16 * 1024)

#define FILE_NEED_REBOOT L".ovpn_need_reboot"
#define FILE_NEED_REBOOT L".ovpn_need_reboot"

#define OPENVPN_CONNECT_ADAPTER_SUBSTR L"OpenVPN Connect"

Expand All @@ -88,7 +89,9 @@ setup_sequence(
free(szSequence);
if (uiResult != ERROR_SUCCESS)
{
SetLastError(uiResult); /* MSDN does not mention MsiSetProperty() to set GetLastError(). But we do have an error code. Set last error manually. */
/* MSDN does not mention MsiSetProperty() to set GetLastError(). But we do have an error
* code. Set last error manually. */
SetLastError(uiResult);
msg(M_NONFATAL | M_ERRNO, "%s: MsiSetProperty(\"%" PRIsLPTSTR "\") failed", __FUNCTION__, szProperty);
return uiResult;
}
Expand Down
2 changes: 1 addition & 1 deletion src/openvpnmsica/openvpnmsica.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
*/
struct openvpnmsica_thread_data
{
MSIHANDLE hInstall; /** Handle to the installation session. */
MSIHANDLE hInstall; /**< Handle to the installation session. */
};


Expand Down
8 changes: 4 additions & 4 deletions src/tapctl/tap.h
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,11 @@ tap_set_adapter_name(
*/
struct tap_adapter_node
{
GUID guid; /** Adapter GUID */
LPTSTR szzHardwareIDs; /** Device hardware ID(s) */
LPTSTR szName; /** Adapter name */
GUID guid; /**< Adapter GUID */
LPTSTR szzHardwareIDs; /**< Device hardware ID(s) */
LPTSTR szName; /**< Adapter name */

struct tap_adapter_node *pNext; /** Pointer to next adapter */
struct tap_adapter_node *pNext; /**< Pointer to next adapter */
};


Expand Down

0 comments on commit 6c636f5

Please sign in to comment.