Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pagerduty #6

Merged
merged 3 commits into from
Dec 20, 2021
Merged

Add Pagerduty #6

merged 3 commits into from
Dec 20, 2021

Conversation

keguchi2114
Copy link
Contributor

This PR is a part of feature request OpenTSDB/opentsdb-alerting#10

@ykawamot ykawamot mentioned this pull request Dec 16, 2021
Open
anonthing
anonthing approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@anonthing anonthing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe add PagerDuty to the test case in ContactServiceTest.java

@keguchi2114
Copy link
Contributor Author

Thanks for review.

I have implemented the test code.
Please check it.

@anonthing anonthing merged commit 97b7b56 into OpenTSDB:master Dec 20, 2021
@keguchi2114 keguchi2114 deleted the feat/pagerduty branch December 22, 2021 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonthing anonthing anonthing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keguchi2114 @anonthing