Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimizing Lever display for digital. #1215

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Optimizing Lever display for digital. #1215

merged 1 commit into from
Nov 25, 2024

Conversation

j-wut
Copy link
Contributor

@j-wut j-wut commented Nov 15, 2024

Optimizing Lever display logic for digital dpad
fixing bug for SOCD-N

@j-wut
Copy link
Contributor Author

j-wut commented Nov 20, 2024 •
edited
Loading

pre fix:
all buttons
pre_all
left + right + down
pre_left_right_down
left + right
pre_left_right
left + up + down
pre_left_up_down
right + up + down
pre_right_up_down
up + down
pre_up_down

post fix:
left + right + down
post_left_right_down
left + right + up
post_left_right_up
left + right
post_left_right
left + up + down
post_left_up_down
right + up + down
post_right_up_down
up + down
post_up_down

@mikepparks
Copy link
Contributor

I'll give this a look with a bigger display this weekend and see how things look. Trivial enough of a fix at least. Good catch.

arntsonl
arntsonl approved these changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@arntsonl arntsonl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! thank you for updating the output results and showing the issue / fix in action.

@arntsonl arntsonl merged commit 5e58441 into OpenStickCommunity:main Nov 25, 2024
44 checks passed
@j-wut j-wut deleted the fix/lever_display_optimizations branch December 6, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arntsonl arntsonl arntsonl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-wut @mikepparks @arntsonl