Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing no power when integrated lights are on #142

Merged
merged 3 commits into from
Sep 28, 2020
Merged

Fixing no power when integrated lights are on #142

merged 3 commits into from
Sep 28, 2020

Conversation

NicobobinusX
Copy link
Contributor

@NicobobinusX NicobobinusX commented Sep 28, 2020 •
edited
Loading

My attempt to apply the fix suggested by djwlindenaar in "#128" to the current V1.0 code. Seems to run smoothly and performance appears equivalent whether lights are on or off.

Compared with another fix of updating line 485 to "if (ui8_g_duty_cycle > 10)", I found this version to feel more responsive.

Other past issues where similar issues are referenced:

  1. (Still) no pedaling support when light's are on. #139
  2. Support stops after pedaling stop with lights on (0.18.1) #71
  3. Motor assistance does not resume after standstill when lights are on #94
  4. SW102: lights not working Color_LCD#104

@NicobobinusX
Update motor.c
e491065 
My attempt to apply the fix suggested by djwlindenaar in "OpenSourceEBike#128"  to the current V1.0 code.  Seems to run smoothly and performance appears equivalent whether lights are on or off.  

Other past issues where similar issues are referenced:
1.  OpenSourceEBike#71
2.  OpenSourceEBike#94
3.  OpenSourceEBike/Color_LCD#104
@NicobobinusX
Update motor.c
9855319 
corrections
@NicobobinusX
Update motor.c
2881cdd
@NicobobinusX
Copy link
Contributor Author

Used #128 as a reference, updating variables to be consistent with V1.0 code. #128 code referenced:
image

This was referenced Sep 28, 2020
Closed
Open
@casainho casainho merged commit cca0307 into OpenSourceEBike:master Sep 28, 2020
@casainho casainho mentioned this pull request Sep 28, 2020
Closed
@casainho
Copy link
Contributor

Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NicobobinusX @casainho