Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Switch to OpenSLO SDK #341

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

nieomylnieja
Copy link
Member

@nieomylnieja nieomylnieja commented Nov 21, 2024

Summary

  • Removed convert subcommand. It was not maintained anymore (for the past 2 years+) and we agreed last year to encourage developing custom converters outside of oslo project.
  • Removed pkg. The utlities which were exposed there can now be replaced with OpenSLO SDK.
    If there are functions missing from the SDK, we expect them to be implemented in the SDK, oslo will no longer be a Go library.
  • Refactored the whole project, moving pkg to internal, removing bloated packages.
  • Added JSON format support to fmt subcommand.
  • Copied golangci-lint config from OpenSLO SDK.
  • Bumped Go version to 1.23 and removed unused dependencies.

Out of scope

After this PR is merged, but BEFORE a new oslo versions is released we need to cover the bats test cases.
We should also introduce similar dev utilities we currently have in OpenSLO SDK (like devbox).

@nieomylnieja
Copy link
Member Author

Once OpenSLO/OpenSLO#313 is merged, I will create an RC version and use that instead of the commit hash.

@nieomylnieja nieomylnieja marked this pull request as ready for review November 21, 2024 14:29
@nieomylnieja nieomylnieja added this to the v1.0.0 milestone Nov 21, 2024
@nieomylnieja nieomylnieja self-assigned this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant