Skip to content

Commit

Permalink
proto_bin: Bump 'bin_async_max_postponed_chunks' 32 -> 1024
Browse files Browse the repository at this point in the history
The default of 32 chunks was too low, considering that BIN TCP conns are
very low in count (often a handful of nodes!), while also transporting
large volums of data within short periods of time (e.g. dialog/usrloc
syncs), so async data buffering may often occur.

(cherry picked from commit 1f17e30)
  • Loading branch information
liviuchircu committed Dec 3, 2024
1 parent d03a686 commit c4b9c53
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions modules/proto_bin/doc/proto_bin_admin.xml
Original file line number Diff line number Diff line change
Expand Up @@ -159,14 +159,14 @@ modparam("proto_bin", "bin_async", 0)
</para>
<para>
<emphasis>
Default value is 32.
Default value is 1024.
</emphasis>
</para>
<example>
<title>Set <varname>bin_async_max_postponed_chunks</varname> parameter</title>
<programlisting format="linespecific">
...
modparam("proto_bin", "bin_async_max_postponed_chunks", 16)
modparam("proto_bin", "bin_async_max_postponed_chunks", 1024)
...
</programlisting>
</example>
Expand Down
2 changes: 1 addition & 1 deletion modules/proto_bin/proto_bin.c
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ static int bin_send_timeout = 100;
static struct tcp_req bin_current_req;
static int bin_max_msg_chunks = 32;
static int bin_async = 1;
static int bin_async_max_postponed_chunks = 32;
static int bin_async_max_postponed_chunks = 1024;
static int bin_async_local_connect_timeout = 100;
static int bin_async_local_write_timeout = 10;

Expand Down

0 comments on commit c4b9c53

Please sign in to comment.