-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix backticks breaking query #293
base: master
Are you sure you want to change the base?
Conversation
The backtick works fine for mysql but breaks for postgres. Mysql supports double quotes too for identifiers .https://dev.mysql.com/doc/refman/8.0/en/sql-mode.html#sqlmode_ansi_quotes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @greenbea! Just left a quick improvement suggestion for you to evaluate before we merge.
You have to set the sql_mode. Try
|
Hi @greenbea! I just pushed a new branch for working on this issue (bugfix/fix-dashboard-postgres), with a preliminary fix, inspired by the discussion so far. Could you please check that commit / approach and see if it fixes the dashboard on your Postgres setup? In short, there are lots of |
No description provided.