Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a guide for (new) contributors #117

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add a guide for (new) contributors #117

wants to merge 4 commits into from

Conversation

Nakaner
Copy link
Collaborator

@Nakaner Nakaner commented Nov 25, 2023

This guide collects remarks I or others have made frequently to pull requests. Feel free to comment.


## Code formatting

We use two spaces for indentation in our MapCSS and YAML files.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's worth adding an editorconfig file to the repo for this purpose?

CONTRIBUTING.md Outdated Show resolved Hide resolved
@besentv
Copy link
Contributor

besentv commented Nov 25, 2023

Also, maybe a bit of an off topic question, but when are updates transferred to the website?
It seems to be stuck on bb7d5e3.

@DerDakon
Copy link
Contributor

Also, maybe a bit of an off topic question, but when are updates transferred to the website? It seems to be stuck on bb7d5e3.

It's not, but only tiles that are rerendered will use the new style. This happens either because of forcing them dirty or if anything inside the data changes.

@besentv
Copy link
Contributor

besentv commented Nov 26, 2023

Also, maybe a bit of an off topic question, but when are updates transferred to the website? It seems to be stuck on bb7d5e3.

It's not, but only tiles that are rerendered will use the new style. This happens either because of forcing them dirty or if anything inside the data changes.

That's odd because I've marked multiple tiles with a Zs6 as dirty, and they still don't show up on the website. Locally it works fine.

@besentv
Copy link
Contributor

besentv commented Nov 27, 2023

Okay it seems to render with master since last night.

Copy link
Contributor

@bjoernma bjoernma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea to have it a bit on point. Thanks :)

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Nakaner Nakaner mentioned this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants