make client testable + first sync test #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhavajay
reviewed
Oct 10, 2024
| @@ -9,7 +9,7 @@ | |||
| class SyftBaseModel(BaseModel): | |||
madhavajay
reviewed
Oct 10, 2024
| @@ -40,6 +40,7 @@ build-backend = "setuptools.build_meta" | |||
| # this will be completely ignored in the built wheel | |||
| dev-dependencies = [ | |||
| "bump2version>=1.0.1", | |||
| "faker>=30.3.0", | |||
There was a problem hiding this comment.
I added this coz it was missing
madhavajay
reviewed
Oct 10, 2024
| stop_event = Event() | ||
|
|
||
|
|
||
| def register(client_config): | ||
| response = requests.post( | ||
| f"{client_config.server_url}/register", | ||
| response = client_config.server_client.post( |
madhavajay
reviewed
Oct 10, 2024
| @@ -244,7 +243,7 @@ def push_changes(client_config: ClientConfig, changes: list[FileChange]): | |||
| try: | |||
| data = { | |||
| "email": client_config.email, | |||
| "change": change.model_dump(), | |||
| "change": change.model_dump(mode="json"), | |||
There was a problem hiding this comment.
id like to move to yaml when we can its much easier to edit in text editors and already enforces line spacing so its much easier to read
madhavajay
reviewed
Oct 10, 2024
| @@ -336,15 +335,15 @@ def list_datasites(client_config): | |||
| return datasites | |||
|
|
|||
|
|
|||
| def get_remote_state(client_config, sub_path: str): | |||
| def get_remote_state(client_config: ClientConfig, sub_path: str): | |||
There was a problem hiding this comment.
I think we can rename ClientConfig to just Client
madhavajay
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
includes changes from #79
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist