Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add server settings, remove server globals #74

Merged
merged 2 commits into from
Oct 9, 2024
Merged

add server settings, remove server globals #74

merged 2 commits into from
Oct 9, 2024

Conversation

eelcovdw
Copy link
Contributor

@eelcovdw eelcovdw commented Oct 9, 2024 •
edited
Loading

Description

note: switching everyting to pathlib in a later PR, this is just to get things ready for user management pr

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

@eelcovdw eelcovdw requested review from madhavajay and abyesilyurt and removed request for madhavajay October 9, 2024 10:52
abyesilyurt
abyesilyurt approved these changes Oct 9, 2024
View reviewed changes
syftbox/server/server.py Show resolved Hide resolved
syftbox/server/settings.py Show resolved Hide resolved
@eelcovdw eelcovdw merged commit 3baef0a into main Oct 9, 2024
7 checks passed
@yashgorana yashgorana deleted the eelco/server-settings branch October 11, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abyesilyurt abyesilyurt abyesilyurt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eelcovdw @abyesilyurt