Skip to content

Commit

Permalink
Merge pull request #265 from OpenMined/feature/enhance_app_run_logs
Browse files Browse the repository at this point in the history
feat(syftbox/client/plugins/apps.py): Replace default app run error m…
  • Loading branch information
IonesioJunior authored Oct 24, 2024
2 parents 8fe7bfd + 6bd2aaf commit 292d33a
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions syftbox/client/plugins/apps.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ def find_and_run_script(task_path, extra_args):

# logger.info("✅ Script run.sh executed successfully.")
return result
except Exception as e:
logger.info(f"Error running shell script {e}")
except subprocess.CalledProcessError as e:
logger.info(f"Error running shell script: {str(e.stderr)}")
else:
raise FileNotFoundError(f"run.sh not found in {task_path}")

Expand Down Expand Up @@ -178,8 +178,7 @@ def run_custom_app_config(client_config, app_config, path):
logger.info(result.stdout)
logger.error(result.stderr)
except subprocess.CalledProcessError as e:
logger.error(f"Error running {app_name}: {e}")
logger.error(e.stderr)
logger.error(f"Error running {app_name}: {e.stderr}")

if cron_iter is not None:
# Schedule the next exection
Expand Down

0 comments on commit 292d33a

Please sign in to comment.