-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the feature of side navigation and preview. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StarConnor
changed the title
Add the feature of side navigation.
Add the feature of side navigation and preview.
Jul 28, 2024
Fix some bugs left in the last commit. |
Add the feature of preview. ExplainAdjust the display of every sample from static block to the "accordion", which will display the context around the token which has the max activation in the sample (100 tokens before and 100 tokens after) and display the whole sample on the click. ImplementationIn the file
|
fix(ui/preview): enable showing 10 samples within one page
dest1n1s
approved these changes
Jul 29, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a module in
sidenav.tsx
inui/src/components/app/
to support side navigation..side-nav
inui/src/globals.css
and thehtml
CSS snippet is used to make the movement smooth.Add the
id
description of the "Top", "Interp.", "Hist.", "Logits", "Act." to corresponding<div>
components. These serve as the links and side navigation could reach the links through<a href="#xxx">
.To avoid too many sample tabs that could exceed the width of the wrapping card, I split the sample tabs into 2 parts. Because the new analysis seems to use 10 sample configs (i.e. "Top Activation", "Sample 90%", ..., "Sample 10%"), the split seems to be perfectly fitted with the card width. See figure->