Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrote base level self condition check #3890

Open
wants to merge 1 commit into
base: condition-baseLvl
Choose a base branch
from

Conversation

hexhexD
Copy link
Member

@hexhexD hexhexD commented Oct 23, 2024

I will update wiki once this is merged.

alisonrag
alisonrag previously approved these changes Oct 23, 2024
@ya4ept
Copy link
Contributor

ya4ept commented Oct 23, 2024

On one hand i don't like this change because we break backward compatibility.
On the other hand, the syntax will be simplified a bit.
Please see autoConfChange
we use "lvl "instead of "baseLvl"

EventMacro:

$.lvl    Current base level
$.joblvl    Current job level

we need to decide what name to use next

@ya4ept
Copy link
Contributor

ya4ept commented Oct 23, 2024

we also use "maxBase" here

Why do we use "maxBase" and "minBase" in the "processAutoBuy" function? This function uses the "checkSelfCondition" check, which is included by "maxBase" and "minBase". Need to re-review #2719

@ya4ept ya4ept changed the base branch from master to condition-baseLvl November 4, 2024 19:25
@ya4ept
Copy link
Contributor

ya4ept commented Nov 5, 2024

Renamed "joblvl" to "jobLvl" for the autoConfChange block
Renamed "lvl" to "baseLvl" for the autoConfChange block

We need:

@ya4ept
Copy link
Contributor

ya4ept commented Nov 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants