Send response to npc as quickly as possible #3793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ya4ept
reviewed
Sep 30, 2023
|
@hexhexD please add some description |
|
Thanks for reviewing, I added some explanation and a bit improvement. |
alisonrag
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes artificial delay controlled by
ai_npc_talk_wait_to_answer. Every NPC message 00B4 sets$ai_v{npc_talk}{talk} = 'initiated';, and a NPC dialog menu 00B7 sets$ai_v{'npc_talk'}{'talk'} = 'select';. By returning early onintiated, we can make talking to NPC really fast and makes the bot more enjoyable to use. I have been using this change locally for couple months now and it's working flawlessly, and it doesn't change the behavior of when an NPC sends no response.