To delete #1653
Closed
To delete #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thxtomslf
requested review from
widgetii,
dimerr and
flyrouter
as code owners
thxtomslf
force-pushed
the
master
branch
3 times, most recently
from
0a95020 to
f2f732a
Compare
flyrouter
requested changes
Dec 28, 2024
flyrouter
reviewed
Dec 28, 2024
There was a problem hiding this comment.
his file is not acceptable.
All majestic config changes should be made via the tweaker only.
flyrouter
reviewed
Dec 28, 2024
There was a problem hiding this comment.
This file is not acceptable.
All device profiles will always default to DHCP only.
flyrouter
reviewed
Dec 28, 2024
flyrouter
reviewed
Dec 28, 2024
There was a problem hiding this comment.
The rules for creating configuration files are not followed.
Corrections are required.
flyrouter
reviewed
Dec 28, 2024
There was a problem hiding this comment.
Binary files are not allowed. Rejected.
flyrouter
reviewed
Dec 28, 2024
There was a problem hiding this comment.
Binary files are not allowed. Rejected.
flyrouter
reviewed
Dec 28, 2024
There was a problem hiding this comment.
Incorrect syntax. Changes required.
flyrouter
reviewed
Dec 28, 2024
There was a problem hiding this comment.
Low feasibility.
Try using the built-in "microcom"
|
Not subject to integration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.