Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocompletion Search #76

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Sakshi183
Copy link

Fixes issue:
<#42>

Changes:
On the basis of the user's input I am suggesting what he/she can search from our database.
screen shot 2018-03-03 at 4 06 46 pm

@Sakshi183
Copy link
Author

@AdiChat Please review and suggest any changes.

code/popup.html Outdated
@@ -11,80 +11,272 @@
<link rel="shortcut icon" type="image/png" href="/icon/icon.png"/>
<title>OpenGenus: World's first Offline Search Engine</title>
<meta charset='utf-8'>
<link rel="stylesheet" href="//code.jquery.com/ui/1.12.1/themes/base/jquery-ui.css">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot link to online resources. You have to save them locally and link it. Also, place the css code to its own file and link it.

Same applies to the javascript code.

code/popup.html Outdated



var availableTags = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the tags, you must use tags.json that is available at Cosmos Search.

@AdiChat
Copy link
Member

AdiChat commented Mar 4, 2018

Nice work. Auto-completion is an important feature and will aid users in proceeding to learn new things. 👍

I have added some comments regarding some minor changes. Kindly take a look and make appropriate changes. 👍

@Sakshi183
Copy link
Author

@AdiChat I have made the appropriate changes.Please review the same.

@AdiChat
Copy link
Member

AdiChat commented Mar 7, 2018

A lot of unused files (like .DS_Store) have been associated with this pull request. Kindly remove them 👍

@Sakshi183
Copy link
Author

@AdiChat I have made the appropriate changes.Please review them.

@AdiChat
Copy link
Member

AdiChat commented Mar 9, 2018

In the jQuery folder, there are unused files like LICENSE.txt, PACKAGE.json, AUTHOR.txt and others. It seems you are using two js files so you must remove the rest as we need to keep file size into consideration. Kindly make appropriate changes. 👍

@Sakshi183
Copy link
Author

@AdiChat I have made the appropriate changes.Please review them.

@Sakshi183
Copy link
Author

@AdiChat I have removed the unused files and only kept the required ones as suggested by you.Please review the changes.
screen shot 2018-03-11 at 11 35 55 pm
screen shot 2018-03-11 at 11 36 05 pm
screen shot 2018-03-11 at 11 36 22 pm

@AdiChat
Copy link
Member

AdiChat commented Mar 16, 2018

Nice work 👍

For a particular typed search term, the suggestions must be limited to 5 results. You may choose the 5 results randomly from the suggestion set. Additionally, you might want to make the UI smoother and the suggestions should not displace the page content and should appear over them.

Kindly take a look into this and make appropriate changes 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants