-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocompletion Search #76
base: master
Are you sure you want to change the base?
Conversation
@AdiChat Please review and suggest any changes. |
code/popup.html
Outdated
@@ -11,80 +11,272 @@ | |||
<link rel="shortcut icon" type="image/png" href="/icon/icon.png"/> | |||
<title>OpenGenus: World's first Offline Search Engine</title> | |||
<meta charset='utf-8'> | |||
<link rel="stylesheet" href="//code.jquery.com/ui/1.12.1/themes/base/jquery-ui.css"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You cannot link to online resources. You have to save them locally and link it. Also, place the css code to its own file and link it.
Same applies to the javascript
code.
code/popup.html
Outdated
|
||
|
||
|
||
var availableTags = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the tags, you must use tags.json
that is available at Cosmos Search.
Nice work. Auto-completion is an important feature and will aid users in proceeding to learn new things. 👍 I have added some comments regarding some minor changes. Kindly take a look and make appropriate changes. 👍 |
9e6b18c
to
7ec7916
Compare
@AdiChat I have made the appropriate changes.Please review the same. |
A lot of unused files (like |
@AdiChat I have made the appropriate changes.Please review them. |
In the |
@AdiChat I have made the appropriate changes.Please review them. |
@AdiChat I have removed the unused files and only kept the required ones as suggested by you.Please review the changes. |
Nice work 👍 For a particular typed search term, the suggestions must be limited to 5 results. You may choose the 5 results randomly from the suggestion set. Additionally, you might want to make the UI smoother and the suggestions should not displace the page content and should appear over them. Kindly take a look into this and make appropriate changes 👍 |
Fixes issue:
<#42>
Changes:
On the basis of the user's input I am suggesting what he/she can search from our database.