Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G2P-1397: ID Types Configuration #91

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

dibik96
Copy link
Member

@dibik96 dibik96 commented Oct 29, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (db6ce5e) 64.15% compared to head (744f9f5) 64.04%.
Report is 1 commits behind head on 15.0-develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           15.0-develop      #91      +/-   ##
================================================
- Coverage         64.15%   64.04%   -0.12%     
================================================
  Files                75       75              
  Lines              1476     1485       +9     
  Branches            197      200       +3     
================================================
+ Hits                947      951       +4     
- Misses              501      504       +3     
- Partials             28       30       +2     
Files Coverage Δ
g2p_registry_base/models/reg_id.py 60.00% <58.33%> (-4.52%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shibu-narayanan shibu-narayanan merged commit 2a354a5 into OpenG2P:15.0-develop Oct 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants