Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete content belonging to old paper #561

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

FlorianK13
Copy link
Member

@FlorianK13 FlorianK13 commented Sep 12, 2024

Summary of the discussion

There are old code artefacts that we want to delete.

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@FlorianK13 FlorianK13 linked an issue Sep 12, 2024 that may be closed by this pull request
1 task
@FlorianK13 FlorianK13 marked this pull request as ready for review September 12, 2024 08:11
@FlorianK13
Copy link
Member Author

FlorianK13 commented Sep 12, 2024

@nesnoj are there additional things we want to delete? I think scripts, tests, and postprocessing contains code that is old and outdated.

This could also resolve #555 if we delete requirements.txt that are lying in these folders.

@FlorianK13 FlorianK13 requested a review from nesnoj September 12, 2024 09:15
@nesnoj
Copy link
Collaborator

nesnoj commented Oct 10, 2024

Let's get back to this in our JF

nesnoj
nesnoj previously approved these changes Oct 24, 2024
Copy link
Collaborator

@nesnoj nesnoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add link to the code backup (paper repo @FlorianK13 ) to changelog

@FlorianK13
Copy link
Member Author

I added the link to the CHANGELOG, hence I think we can merge this. Do you agree @nesnoj ?

@nesnoj nesnoj self-requested a review November 5, 2024 13:34
Copy link
Collaborator

@nesnoj nesnoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's fine! Thx for cleaning up!

@FlorianK13 FlorianK13 merged commit 846f814 into develop Nov 5, 2024
9 checks passed
@FlorianK13 FlorianK13 deleted the 552-clean-up-scripts-folder branch November 5, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up scripts folder
2 participants