Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 556 configurable api service port #557

Merged
merged 3 commits into from
Aug 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ and the versioning aims to respect [Semantic Versioning](http://semver.org/spec/
[#549](https://github.com/OpenEnergyPlatform/open-MaStR/issues/549)
- Set pandas version to >=2.2.2 for compatibility with numpy v2.0
[#553](https://github.com/OpenEnergyPlatform/open-MaStR/issues/553)
- Allow to configure model/service port in `soap_api.download.MaStRAPI`
[#556](https://github.com/OpenEnergyPlatform/open-MaStR/issues/556)
### Removed

## [v0.14.4] Release for the Journal of Open Source Software JOSS - 2024-06-07
Expand Down
12 changes: 9 additions & 3 deletions docs/advanced.md
Original file line number Diff line number Diff line change
Expand Up @@ -205,10 +205,16 @@ if __name__ == "__main__":
print(mastr_api.GetLokaleUhrzeit())
```

For API calls and their optional parameters refer to [API documentation](https://www.marktstammdatenregister.
de/MaStRHilfe/subpages/webdienst.html).
The MaStR API has different models to query from, the default are power units
("Anlage"). To change this, you can pass the desired model to
[`MaStRAPI`][open_mastr.soap_api.download.MaStRAPI].
E.g. to query market actors instantiate it using
`MaStRAPI(service_port="Akteur")`.

???+ example "Example queries and their responses"
For API calls, models and optional parameters refer to the
[API documentation](https://www.marktstammdatenregister.de/MaStRHilfe/subpages/webdienst.html).

???+ example "Example queries and their responses (for model 'Anlage')"

=== "mastr_api.GetLokaleUhrzeit()"

Expand Down
34 changes: 20 additions & 14 deletions open_mastr/soap_api/download.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ class MaStRAPI(object):

mastr_api = MaStRAPI(
user="SOM123456789012",
key=""koo5eixeiQuoi'w8deighai8ahsh1Ha3eib3coqu7ceeg%ies..."
key="koo5eixeiQuoi'w8deighai8ahsh1Ha3eib3coqu7ceeg%ies...",
service_port="Anlage"
)
```

Expand Down Expand Up @@ -69,7 +70,7 @@ class MaStRAPI(object):
wrapped SOAP queries. This is handled internally.
"""

def __init__(self, user=None, key=None):
def __init__(self, user=None, key=None, service_port="Anlage"):
"""
Parameters
----------
Expand All @@ -80,10 +81,15 @@ def __init__(self, user=None, key=None):
key : str , optional
Access token of a role (Benutzerrolle). Might look like:
"koo5eixeiQuoi'w8deighai8ahsh1Ha3eib3coqu7ceeg%ies..."
service_port : str , optional
Port/model to be used, e.g. "Anlage" or "Akteur", see docs for
full list:
https://www.marktstammdatenregister.de/MaStRHilfe/subpages/webdienst.html
Defaults to "Anlage".
"""

# Bind MaStR SOAP API functions as instance methods
client, client_bind = _mastr_bindings()
client, client_bind = _mastr_bindings(service_port=service_port)

# First, all services of registered service_port (i.e. 'Anlage')
for n, f in client_bind:
Expand Down Expand Up @@ -140,19 +146,27 @@ def wrapper(*args, **kwargs):


def _mastr_bindings(
service_port,
service_name="Marktstammdatenregister",
wsdl="https://www.marktstammdatenregister.de/MaStRAPI/wsdl/mastr.wsdl",
max_retries=3,
pool_connections=100,
pool_maxsize=100,
timeout=60,
operation_timeout=600,
wsdl="https://www.marktstammdatenregister.de/MaStRAPI/wsdl/mastr.wsdl",
service_name="Marktstammdatenregister",
service_port="Anlage",
):
"""

Parameters
----------
service_port : str
Port of service to be used. Parameters is passed to `zeep.Client.bind`
See :class:`MaStRAPI` for more information.
service_name : str
Service, defined in wsdl file, that is to be used. Parameters is
passed to zeep.Client.bind
wsdl : str
Url of wsdl file to be used. Parameters is passed to zeep.Client
max_retries : int
Maximum number of retries for a request. Parameters is passed to
requests.adapters.HTTPAdapter
Expand All @@ -168,14 +182,6 @@ def _mastr_bindings(
operation_timeout : int
Timeout for API requests (GET/POST in underlying requests package)
in seconds. Parameter is passed to `zeep.transports.Transport`.
wsdl : str
Url of wsdl file to be used. Parameters is passed to zeep.Client
service_name : str
Service, defined in wsdl file, that is to be used. Parameters is
passed to zeep.Client.bind
service_port : str
Port of service to be used. Parameters is
passed to zeep.Client.bind

Returns
-------
Expand Down