Cope with extra tokens after proc statements #2116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ike709
commented
Nov 30, 2024
Comment on lines
-1128
to
+1130
| Whitespace(); | ||
| Check(TokenType.DM_Colon); | ||
| if (Check(TokenType.DM_Colon) || Check(TokenType.DM_Period)) { | ||
| Emit(WarningCode.ExtraToken, loc, "Extra token at end of proc statement"); | ||
| } |
There was a problem hiding this comment.
Checking for whitespace first would cause if(foo) . += "bar" to be caught, which is paraphrased from actual SS13 code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trailing
.and:tokens afterif()andfor()statements is valid in BYOND:We already handled
if():so I just expanded our copium and fixed & extended a broken unit test in the process. Added theExtraTokenstylistic pragma for when this happens. No hits on TG/goon/para.