Master generic netcdf #73

sumihar · 2019-03-07T10:55:23Z

No description provided.

wkramer · 2019-03-18T15:11:26Z

Ik stel voor dat ik donderdag met Julius de Code Quality issues oplos voordat we deze pull request verwerken.

nilsvanvelzen · 2020-01-28T19:00:31Z

Here is an overview of what got changed by this pull request:

Issues
======
- Added 39
           

Complexity increasing per file
==============================
- core/java/test/org/openda/exchange/dataobjects/GenericNetcdfDataObjectTest.java  2
- core/java/src/org/openda/exchange/dataobjects/GenericNetcdfTSExchangeItem.java  2
- core/java/src/org/openda/exchange/dataobjects/GenericNetcdfDataObject.java  33
- core/java/src/org/openda/exchange/dataobjects/GenericNetcdfConfigReader.java  7
- core/java/src/org/openda/exchange/dataobjects/GenericNetcdfArrayConfig.java  1
- core/java/src/org/openda/exchange/GenericNetcdfArrayExchangeItem.java  4
- core/java/src/org/openda/exchange/dataobjects/GenericNetcdfTSConfig.java  8
         

Clones added
============
- core/java/src/org/openda/exchange/dataobjects/GenericNetcdfDataObject.java  2
- core/java/src/org/openda/exchange/GenericNetcdfArrayExchangeItem.java  1

See the complete overview on Codacy

nilsvanvelzen · 2020-01-28T19:00:31Z

core/java/src/org/openda/exchange/dataobjects/GenericNetcdfDataObject.java

+			String dimensionVariable = arrayConfig.getNetcdfDimensionVariables()[iDimVar];
+			int dimIndex = variable.findDimensionIndex(dimensionVariable);
+			if (dimIndex==-1){
+				throw new RuntimeException("GenericNetcdfDataObject, variable " + variableName + " doesn't have the following dimension-variable: " + dimensionVariable);


Issue found: Avoid throwing raw exception types.

nilsvanvelzen · 2020-01-28T19:00:33Z

core/java/test/org/openda/exchange/dataobjects/GenericNetcdfDataObjectTest.java

+import java.io.File;
+
+public class GenericNetcdfDataObjectTest extends TestCase {
+	private OpenDaTestSupport testData;


Issue found: Perhaps 'testData' could be replaced by a local variable.

nilsvanvelzen · 2020-01-28T19:00:34Z

core/java/src/org/openda/exchange/dataobjects/GenericNetcdfTSExchangeItem.java

+
+	@Override
+	public Role getRole() {
+		throw new RuntimeException("org.openda.exchange.dataobjects.GenericNetcdfTSExchangeItem.getRole not implemented yet");


Issue found: Avoid throwing raw exception types.

nilsvanvelzen · 2020-01-28T19:00:35Z

core/java/src/org/openda/exchange/GenericNetcdfArrayExchangeItem.java

+
+	@Override
+	public Class getValueType() {
+		throw new RuntimeException("org.openda.exchange.GenericNetcdfArrayExchangeItem.getValueType not implemented yet");


Issue found: Avoid throwing raw exception types.

nilsvanvelzen · 2020-01-28T19:00:37Z

core/java/src/org/openda/exchange/GenericNetcdfArrayExchangeItem.java

+
+	@Override
+	public ValueType getValuesType() {
+		throw new RuntimeException("org.openda.exchange.GenericNetcdfArrayExchangeItem.getValuesType not implemented yet");


Issue found: Avoid throwing raw exception types.

nilsvanvelzen · 2020-01-28T19:00:38Z

core/java/src/org/openda/exchange/dataobjects/GenericNetcdfTSExchangeItem.java

@@ -0,0 +1,102 @@
+package org.openda.exchange.dataobjects;
+
+import org.openda.interfaces.*;


Issue found: Avoid unused imports such as 'org.openda.interfaces'

nilsvanvelzen · 2020-01-28T19:00:39Z

core/java/src/org/openda/exchange/dataobjects/GenericNetcdfDataObject.java

+					for (String valuesDimensionName : valuesDimension.keySet()) {
+						dimIndex = valuesVariable.findDimensionIndex(valuesDimensionName);
+						if (dimIndex == -1) {
+							throw new RuntimeException("GenericNetcdfDataObject, TimeSeries, variable " + tsConfig.getValuesVariableName() + " doesn't have the following dimension-variable: " + valuesDimensionName);


Issue found: Avoid throwing raw exception types.

nilsvanvelzen · 2020-01-28T19:00:40Z

core/java/src/org/openda/exchange/dataobjects/GenericNetcdfTSExchangeItem.java

+
+	@Override
+	public void setValuesAsDoubles(double[] values) {
+		throw new RuntimeException("org.openda.exchange.dataobjects.GenericNetcdfTSExchangeItem.setValuesAsDoubles not implemented yet");


Issue found: Avoid throwing raw exception types.

nilsvanvelzen · 2020-01-28T19:00:41Z

core/java/src/org/openda/exchange/dataobjects/GenericNetcdfTSExchangeItem.java

+
+	@Override
+	public void setValues(Object values) {
+		throw new RuntimeException("org.openda.exchange.dataobjects.GenericNetcdfTSExchangeItem.setValues not implemented yet");


Issue found: Avoid throwing raw exception types.

nilsvanvelzen · 2020-01-28T19:00:42Z

core/java/src/org/openda/exchange/dataobjects/GenericNetcdfTSExchangeItem.java

+
+	@Override
+	public IGeometryInfo getGeometryInfo() {
+		throw new RuntimeException("org.openda.exchange.dataobjects.GenericNetcdfTSExchangeItem.getGeometryInfo not implemented yet");


Issue found: Avoid throwing raw exception types.

nilsvanvelzen · 2020-01-28T19:00:43Z

core/java/src/org/openda/exchange/dataobjects/GenericNetcdfTSConfig.java

+		this.template = template;
+		if (timeseriesExchangeItemXML.getMeta() != null){
+			if (timeseriesExchangeItemXML.getMeta().getLocation() == null){
+				throw new RuntimeException("GenericNetcdfTSConfig: <location> is missing in <meta>. Please check the configuration file.");


Issue found: Avoid throwing raw exception types.

nilsvanvelzen · 2020-01-28T19:00:44Z

core/java/src/org/openda/exchange/GenericNetcdfArrayExchangeItem.java

+
+	@Override
+	public void multiplyValues(double[] multiplicationFactors) {
+		throw new RuntimeException("org.openda.exchange.GenericNetcdfArrayExchangeItem.multiplyValues not implemented yet");


Issue found: Avoid throwing raw exception types.

nilsvanvelzen · 2020-01-28T19:00:45Z

core/java/src/org/openda/exchange/dataobjects/GenericNetcdfTSExchangeItem.java

+
+	@Override
+	public String getDescription() {
+		throw new RuntimeException("org.openda.exchange.dataobjects.GenericNetcdfTSExchangeItem.getDescription not implemented yet");


Issue found: Avoid throwing raw exception types.

nilsvanvelzen · 2020-01-28T19:00:47Z

core/java/src/org/openda/exchange/dataobjects/GenericNetcdfDataObject.java

+import org.openda.interfaces.IDataObject;
+import org.openda.interfaces.IExchangeItem;
+import org.openda.interfaces.IPrevExchangeItem;
+import org.openda.utils.Array;


Issue found: Avoid unused imports such as 'org.openda.utils.Array'

nilsvanvelzen · 2020-01-28T19:00:49Z

core/java/src/org/openda/exchange/dataobjects/GenericNetcdfTSConfig.java

@@ -0,0 +1,98 @@
+package org.openda.exchange.dataobjects;
+
+import org.openda.core.io.castorgenerated.*;


Issue found: Avoid unused imports such as 'org.openda.core.io.castorgenerated'

nilsvanvelzen · 2020-01-28T19:00:49Z

core/java/src/org/openda/exchange/dataobjects/GenericNetcdfTSExchangeItem.java

+
+	@Override
+	public void copyValuesFromItem(IExchangeItem sourceItem) {
+		throw new RuntimeException("org.openda.exchange.dataobjects.GenericNetcdfTSExchangeItem.copyValuesFromItem not implemented yet");


Issue found: Avoid throwing raw exception types.

nilsvanvelzen · 2020-01-28T19:00:51Z

core/java/src/org/openda/exchange/dataobjects/GenericNetcdfTSExchangeItem.java

+
+	@Override
+	public ValueType getValuesType() {
+		throw new RuntimeException("org.openda.exchange.dataobjects.GenericNetcdfTSExchangeItem.getValuesType not implemented yet");


Issue found: Avoid throwing raw exception types.

nilsvanvelzen · 2020-01-28T19:00:52Z

core/java/src/org/openda/exchange/dataobjects/GenericNetcdfDataObject.java

+import org.openda.interfaces.IDataObject;
+import org.openda.interfaces.IExchangeItem;
+import org.openda.interfaces.IPrevExchangeItem;
+import org.openda.utils.Array;


Issue found: Unused import - org.openda.utils.Array.

nilsvanvelzen · 2020-01-28T19:00:53Z

core/java/src/org/openda/exchange/dataobjects/GenericNetcdfTSExchangeItem.java

+
+	@Override
+	public void setTimes(double[] times) {
+		throw new RuntimeException("org.openda.exchange.dataobjects.GenericNetcdfTSExchangeItem.setTimes not implemented yet");


Issue found: Avoid throwing raw exception types.

nilsvanvelzen · 2020-01-28T19:00:54Z

core/java/src/org/openda/exchange/dataobjects/GenericNetcdfConfig.java

@@ -0,0 +1,13 @@
+package org.openda.exchange.dataobjects;
+
+import java.util.ArrayList;


Issue found: Unused import - java.util.ArrayList.

nilsvanvelzen · 2020-01-28T19:00:55Z

core/java/src/org/openda/exchange/GenericNetcdfArrayExchangeItem.java

+
+	@Override
+	public void setValues(Object values) {
+		throw new RuntimeException("org.openda.exchange.GenericNetcdfArrayExchangeItem.setValues not implemented yet");


Issue found: Avoid throwing raw exception types.

nilsvanvelzen · 2020-01-28T19:00:56Z

core/java/src/org/openda/exchange/dataobjects/GenericNetcdfTSExchangeItem.java

+
+	@Override
+	public void multiplyValues(double[] multiplicationFactors) {
+		throw new RuntimeException("org.openda.exchange.dataobjects.GenericNetcdfTSExchangeItem.multiplyValues not implemented yet");


Issue found: Avoid throwing raw exception types.

nilsvanvelzen · 2020-01-28T19:00:57Z

core/java/src/org/openda/exchange/dataobjects/GenericNetcdfConfig.java

+//	ArrayList<GenericNetcdfArrayConfig> arrayConfigs = new ArrayList<>();
+
+	HashMap<String, GenericNetcdfTSConfig> tsConfigs = new HashMap<>();
+	HashMap<String, GenericNetcdfArrayConfig> arrayConfigs = new HashMap<>();


Issue found: Use explicit scoping instead of the default package private level

nilsvanvelzen · 2020-01-28T19:00:58Z

core/java/src/org/openda/exchange/dataobjects/GenericNetcdfTSExchangeItem.java

+
+	@Override
+	public Class getValueType() {
+		throw new RuntimeException("org.openda.exchange.dataobjects.GenericNetcdfTSExchangeItem.getValueType not implemented yet");


Issue found: Avoid throwing raw exception types.

nilsvanvelzen · 2020-01-28T19:00:59Z

core/java/src/org/openda/exchange/dataobjects/GenericNetcdfTSExchangeItem.java

+
+	@Override
+	public IQuantityInfo getQuantityInfo() {
+		throw new RuntimeException("org.openda.exchange.dataobjects.GenericNetcdfTSExchangeItem.getQuantityInfo not implemented yet");


Issue found: Avoid throwing raw exception types.

sumihar added 2 commits March 7, 2019 11:49

Update .gitignore

8b53dbf

New GenericNetcdfDataObject

7e8e233

sumihar assigned stefhummel Mar 7, 2019

nilsvanvelzen reviewed Jan 28, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Master generic netcdf #73

Master generic netcdf #73

sumihar commented Mar 7, 2019

wkramer commented Mar 18, 2019

nilsvanvelzen commented Jan 28, 2020

nilsvanvelzen Jan 28, 2020

nilsvanvelzen Jan 28, 2020

nilsvanvelzen Jan 28, 2020

nilsvanvelzen Jan 28, 2020

nilsvanvelzen Jan 28, 2020

nilsvanvelzen Jan 28, 2020

nilsvanvelzen Jan 28, 2020

nilsvanvelzen Jan 28, 2020

nilsvanvelzen Jan 28, 2020

nilsvanvelzen Jan 28, 2020

nilsvanvelzen Jan 28, 2020

nilsvanvelzen Jan 28, 2020

nilsvanvelzen Jan 28, 2020

nilsvanvelzen Jan 28, 2020

nilsvanvelzen Jan 28, 2020

nilsvanvelzen Jan 28, 2020

nilsvanvelzen Jan 28, 2020

nilsvanvelzen Jan 28, 2020

nilsvanvelzen Jan 28, 2020

nilsvanvelzen Jan 28, 2020

nilsvanvelzen Jan 28, 2020

nilsvanvelzen Jan 28, 2020

nilsvanvelzen Jan 28, 2020

nilsvanvelzen Jan 28, 2020

nilsvanvelzen Jan 28, 2020

		@@ -0,0 +1,102 @@
		package org.openda.exchange.dataobjects;

		import org.openda.interfaces.*;

		@@ -0,0 +1,98 @@
		package org.openda.exchange.dataobjects;

		import org.openda.core.io.castorgenerated.*;

		@@ -0,0 +1,13 @@
		package org.openda.exchange.dataobjects;

		import java.util.ArrayList;

Master generic netcdf #73

Are you sure you want to change the base?

Master generic netcdf #73

Conversation

sumihar commented Mar 7, 2019

wkramer commented Mar 18, 2019

nilsvanvelzen commented Jan 28, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment