-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Efdc mpi #366
base: master
Are you sure you want to change the base?
Commits on Jan 26, 2024
-
EFDC: Remove OpenMP parallelisation AIX version
This removes OpenMP-based parallelisations that are present originating from the AIX-based versions. These are removed to make place for an updated, hybrid MPI & OpenMP approach.
Configuration menu - View commit details
-
Copy full SHA for 5e694ee - Browse repository at this point
Copy the full SHA 5e694eeView commit details -
fixup: Remove OMP loops in additional files
Considers files: - CALAVBOLD.for - CALEXP2T0.for - CALPUV2C.for
Configuration menu - View commit details
-
Copy full SHA for c6c040b - Browse repository at this point
Copy the full SHA c6c040bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d05dd3b - Browse repository at this point
Copy the full SHA d05dd3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4162d3f - Browse repository at this point
Copy the full SHA 4162d3fView commit details -
Replace write FMT containing bracketed variables
This fix resolves the patch applied in OpenDA that comments out these print statements, specifically `CGATEFLX.patch` and `RWQC1.patch`.
Configuration menu - View commit details
-
Copy full SHA for c65b91c - Browse repository at this point
Copy the full SHA c65b91cView commit details -
Replace deprecated
PAUSE
call withREAD
A print is inserted before invoking `READ(*,*)` to notify the user of the suspended state of the application. This is similar to the message emitted by `PAUSE`. The behaviour is now slightly different: - To continue: ENTER should be provided in stead of 'go'; - To terminate: a signal needs to be sent manually.
Configuration menu - View commit details
-
Copy full SHA for 49fb53b - Browse repository at this point
Copy the full SHA 49fb53bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c02de7 - Browse repository at this point
Copy the full SHA 5c02de7View commit details -
Resolve warning regarding lines with unused labels
This resolves the warnings raised by the compiler due to lines containing unused jump labels. For lines that only contain format specifiers or CONTINUE statements, the lines are commented. For lines that contain other instructions, such as calls to READ, only the label is removed.
Configuration menu - View commit details
-
Copy full SHA for 231c08c - Browse repository at this point
Copy the full SHA 231c08cView commit details -
Replace non-standard function SECNDS by SECOND
The non-standard function SECNDS is replaced by SECOND throughout the source code. Since the alternative SECOND does not allow to provide a reference time, the time difference is obtained by subtracting the original reference value instead. For details on the non-standard call: https://gcc.gnu.org/onlinedocs/gcc-4.9.4/gfortran/SECNDS.html
Configuration menu - View commit details
-
Copy full SHA for 075e74a - Browse repository at this point
Copy the full SHA 075e74aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9606649 - Browse repository at this point
Copy the full SHA 9606649View commit details -
Resolve warning infinite loop on READ branch
This makes the implicit while loop for the READ statements explicit by moving the READ statement into a `DO WHILE` statement that runs until a satisfactory read is performed. This does not change the functionality, it merely makes the loop explicit and thereby suppresses the compiler warnings.
Configuration menu - View commit details
-
Copy full SHA for 9df3514 - Browse repository at this point
Copy the full SHA 9df3514View commit details -
Resolve compiler warnings due to
Wconversion
All implicit conversion is made explicit by inserting the required type casts to match the assigned variables.
Configuration menu - View commit details
-
Copy full SHA for 1342731 - Browse repository at this point
Copy the full SHA 1342731View commit details -
Initialise variables that are maybe uninitialised
This resolves the corresponding warnings raised by `-Wmaybe-uninitialized`.
Configuration menu - View commit details
-
Copy full SHA for 83f2dfc - Browse repository at this point
Copy the full SHA 83f2dfcView commit details -
Revert "Resolve warning infinite loop on READ branch"
This reverts commit 3dceaaf.
Configuration menu - View commit details
-
Copy full SHA for 02c772c - Browse repository at this point
Copy the full SHA 02c772cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e511c5e - Browse repository at this point
Copy the full SHA e511c5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 609b5aa - Browse repository at this point
Copy the full SHA 609b5aaView commit details -
Drop unused variables and subroutine CALEBI0
Some of these are old loop variables that were not removed when the corresponding parallel loops were stripped out. Others are simply additional unused variables.
Configuration menu - View commit details
-
Copy full SHA for f5d2d42 - Browse repository at this point
Copy the full SHA f5d2d42View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1e3854 - Browse repository at this point
Copy the full SHA c1e3854View commit details -
Comment variable definitions to match NIER
These are commented here and seem unused.
Configuration menu - View commit details
-
Copy full SHA for 103f940 - Browse repository at this point
Copy the full SHA 103f940View commit details -
Configuration menu - View commit details
-
Copy full SHA for a07100f - Browse repository at this point
Copy the full SHA a07100fView commit details -
Add MPI-based subroutine implementations
The filenames '${NAME}_mpi.for' implement the MPI counter parts of the subroutines present in '${NAME}.for'.
Configuration menu - View commit details
-
Copy full SHA for 5a26a89 - Browse repository at this point
Copy the full SHA 5a26a89View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0bbc7b - Browse repository at this point
Copy the full SHA c0bbc7bView commit details -
Move variables from function args to globals
In NIER these variables are defined in Var_Global_Mod and not explicitly passed towards the subroutines. The subroutine signature is modified accordingly.
Configuration menu - View commit details
-
Copy full SHA for 386639c - Browse repository at this point
Copy the full SHA 386639cView commit details -
Extend Makefile to compile MPI sources
- Replace gfortran with an MPI aware compiler (mpifort) - Add targets for the newly added MPI module and MPI sources - Add compiler flag -fallow-argument-mismatch to suppress errors resulting from type mismatch in MPI library calls.
Configuration menu - View commit details
-
Copy full SHA for 5ae9729 - Browse repository at this point
Copy the full SHA 5ae9729View commit details -
Add README to track questionable patches
Includes a note regarding missing patches in the NIER version of source file CGATEFLX.
Configuration menu - View commit details
-
Copy full SHA for 063ebeb - Browse repository at this point
Copy the full SHA 063ebebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9549c0a - Browse repository at this point
Copy the full SHA 9549c0aView commit details -
Transfer missing loops to WQSKE3
* Add missing Green algae salinity tox loops * Converts .AND. to .OR. to be consistent with all other comparisons * Modify if-statement IWQFCB to check with zero
Configuration menu - View commit details
-
Copy full SHA for e799bf6 - Browse repository at this point
Copy the full SHA e799bf6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 194da9e - Browse repository at this point
Copy the full SHA 194da9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for af6201e - Browse repository at this point
Copy the full SHA af6201eView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe3088f - Browse repository at this point
Copy the full SHA fe3088fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a522707 - Browse repository at this point
Copy the full SHA a522707View commit details -
Configuration menu - View commit details
-
Copy full SHA for 969ab02 - Browse repository at this point
Copy the full SHA 969ab02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ca3bfa - Browse repository at this point
Copy the full SHA 0ca3bfaView commit details -
Configuration menu - View commit details
-
Copy full SHA for fed30eb - Browse repository at this point
Copy the full SHA fed30ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3eb937e - Browse repository at this point
Copy the full SHA 3eb937eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 622b0df - Browse repository at this point
Copy the full SHA 622b0dfView commit details -
Introduce remaining MPI related patches
This introduces the MPI patches present in the original Fortran source files, such as including the MPI module and various occurances of checking the current rank through MYRANK, mostly to guard read, write, or debug statements.
Configuration menu - View commit details
-
Copy full SHA for b724060 - Browse repository at this point
Copy the full SHA b724060View commit details -
Extract OMP thread through OMP_GET_MAX_THREADS
This makes the number of threads extracted consistent with the OpenDA wrapper's approach.
Configuration menu - View commit details
-
Copy full SHA for d4a5587 - Browse repository at this point
Copy the full SHA d4a5587View commit details -
Add MPI init, finialise, and subroutine calls
This propagates the MPI patches into the OpenDA wrapper. The MPI environment is initialised when the wrapper is set up. The domain decomposition seems required before the second model init, as is done in the EFDC.for main file. When the wrapper is destroyed, the MPI environment is destroyed as well. NOTE: This *ONLY* considers running with at most 1 rank and no care is taken to restrict certain operations to only the first rank, as would be needed for file IOa and/or log printing.
Configuration menu - View commit details
-
Copy full SHA for e7f5f74 - Browse repository at this point
Copy the full SHA e7f5f74View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4fa9fa - Browse repository at this point
Copy the full SHA d4fa9faView commit details -
Configuration menu - View commit details
-
Copy full SHA for d638fc1 - Browse repository at this point
Copy the full SHA d638fc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9df1723 - Browse repository at this point
Copy the full SHA 9df1723View commit details -
Configuration menu - View commit details
-
Copy full SHA for a402fef - Browse repository at this point
Copy the full SHA a402fefView commit details -
Configuration menu - View commit details
-
Copy full SHA for e749cca - Browse repository at this point
Copy the full SHA e749ccaView commit details -
Configuration menu - View commit details
-
Copy full SHA for aee29be - Browse repository at this point
Copy the full SHA aee29beView commit details -
Configuration menu - View commit details
-
Copy full SHA for d842b34 - Browse repository at this point
Copy the full SHA d842b34View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29c22b7 - Browse repository at this point
Copy the full SHA 29c22b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for a00e6c1 - Browse repository at this point
Copy the full SHA a00e6c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for ccd9fdb - Browse repository at this point
Copy the full SHA ccd9fdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fc97bf - Browse repository at this point
Copy the full SHA 8fc97bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for ac20b80 - Browse repository at this point
Copy the full SHA ac20b80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3320ef8 - Browse repository at this point
Copy the full SHA 3320ef8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 595e60c - Browse repository at this point
Copy the full SHA 595e60cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 102f8f8 - Browse repository at this point
Copy the full SHA 102f8f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d201f0a - Browse repository at this point
Copy the full SHA d201f0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4744a01 - Browse repository at this point
Copy the full SHA 4744a01View commit details
Commits on Apr 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ebd8990 - Browse repository at this point
Copy the full SHA ebd8990View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd12727 - Browse repository at this point
Copy the full SHA fd12727View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e4e47f - Browse repository at this point
Copy the full SHA 9e4e47fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9034bb3 - Browse repository at this point
Copy the full SHA 9034bb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c9efec - Browse repository at this point
Copy the full SHA 6c9efecView commit details -
Configuration menu - View commit details
-
Copy full SHA for c69aea2 - Browse repository at this point
Copy the full SHA c69aea2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cf736a - Browse repository at this point
Copy the full SHA 9cf736aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f870fef - Browse repository at this point
Copy the full SHA f870fefView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b7bddd - Browse repository at this point
Copy the full SHA 4b7bdddView commit details
Commits on May 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for da64fb2 - Browse repository at this point
Copy the full SHA da64fb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66d01fe - Browse repository at this point
Copy the full SHA 66d01feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5623352 - Browse repository at this point
Copy the full SHA 5623352View commit details
Commits on May 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7b6406b - Browse repository at this point
Copy the full SHA 7b6406bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 64d631e - Browse repository at this point
Copy the full SHA 64d631eView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc0eeb8 - Browse repository at this point
Copy the full SHA cc0eeb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for c21ce8e - Browse repository at this point
Copy the full SHA c21ce8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f7d71f6 - Browse repository at this point
Copy the full SHA f7d71f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f038d0 - Browse repository at this point
Copy the full SHA 1f038d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c7006a - Browse repository at this point
Copy the full SHA 3c7006aView commit details