Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 2e2 tests and restructure the CMake project #48

Merged
merged 4 commits into from
Aug 25, 2023
Merged

Add 2e2 tests and restructure the CMake project #48

merged 4 commits into from
Aug 25, 2023

Conversation

pavel-kirienko
Copy link
Member

  • Add e2e tests.
  • Create a top-level CMakeLists.txt to simplify development.
  • Remove a redundant .clang-format file.

This changeset completes the functionality of the library and its test suite. The missing part is the usage overview for the README and the contributing documentation.

@pavel-kirienko pavel-kirienko self-assigned this Aug 18, 2023
@pavel-kirienko pavel-kirienko marked this pull request as ready for review August 18, 2023 18:59
@lydia-at-amazon lydia-at-amazon self-requested a review August 22, 2023 16:36
thirtytwobits
thirtytwobits previously requested changes Aug 22, 2023
View reviewed changes
Copy link
Member

@thirtytwobits thirtytwobits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only sticking point is documentation on dynamic priority changes (see comments). It'd be nice to have a redundancy e2e test but if you think we've covered this enough elsewhere and if we cover this in the example then I can let it go.

libudpard/udpard.h Outdated Show resolved Hide resolved
tests/CMakeLists.txt Outdated Show resolved Hide resolved
tests/src/test_e2e.cpp Show resolved Hide resolved
tests/src/test_e2e.cpp Show resolved Hide resolved
tests/src/test_e2e.cpp Show resolved Hide resolved
tests/src/test_e2e.cpp Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@pavel-kirienko pavel-kirienko merged commit d0d19ef into main2 Aug 25, 2023
@pavel-kirienko pavel-kirienko deleted the pavel branch August 25, 2023 18:24
@pavel-kirienko pavel-kirienko mentioned this pull request Aug 25, 2023
Merged
pavel-kirienko added a commit that referenced this pull request Aug 30, 2023
@pavel-kirienko
Replace the implementation (#51)
a6980ac 
As the library is functionally complete and is usable, I would like to
continue further development against the main branch. The current
version number is set to v0.1.

There have been no pushes to `main2` since #48.

- closes #40
- closes #32
- closes #29
- closes #28
- closes #26
- closes #24
- closes #22
- closes #21
- closes #16
- closes #14
- closes #13
- closes #10
- closes #7
- closes #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lydia-at-amazon lydia-at-amazon lydia-at-amazon approved these changes

@thirtytwobits thirtytwobits Awaiting requested review from thirtytwobits

Assignees

@pavel-kirienko pavel-kirienko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavel-kirienko @thirtytwobits @lydia-at-amazon