-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented ServerLevel, ServerPlayer, Level, ClientLevel for phase 1 #16
Merged
NotStirred
merged 7 commits into
OpenCubicChunks:MC_1.20_neoforge
from
seelderr:MC_1.20_neoforge_clientlevel
Jan 24, 2024
Merged
Implemented ServerLevel, ServerPlayer, Level, ClientLevel for phase 1 #16
NotStirred
merged 7 commits into
OpenCubicChunks:MC_1.20_neoforge
from
seelderr:MC_1.20_neoforge_clientlevel
Jan 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seelderr
changed the title
Marking ClientLevel for phase 2/3
Implemented ServerLevel, ServerPlayer, Level, ClientLevel for phase 1
Jan 21, 2024
seelderr
force-pushed
the
MC_1.20_neoforge_clientlevel
branch
from
January 21, 2024 07:47
cb864a8
to
dcbe4ed
Compare
I'll go through and update param names after #21 is merged. |
seelderr
force-pushed
the
MC_1.20_neoforge_clientlevel
branch
from
January 22, 2024 00:11
9e4341b
to
6055543
Compare
NotStirred
requested changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small changes to logic, and a nit.
Also you're missing mixin comments explaining what they should do!
...ava/io/github/opencubicchunks/cubicchunks/mixin/core/common/server/MixinMinecraftServer.java
Outdated
Show resolved
Hide resolved
...ain/java/io/github/opencubicchunks/cubicchunks/mixin/core/common/world/level/MixinLevel.java
Outdated
Show resolved
Hide resolved
...ain/java/io/github/opencubicchunks/cubicchunks/mixin/core/common/world/level/MixinLevel.java
Outdated
Show resolved
Hide resolved
...ain/java/io/github/opencubicchunks/cubicchunks/mixin/core/common/world/level/MixinLevel.java
Outdated
Show resolved
Hide resolved
...ain/java/io/github/opencubicchunks/cubicchunks/mixin/core/common/world/level/MixinLevel.java
Outdated
Show resolved
Hide resolved
seelderr
force-pushed
the
MC_1.20_neoforge_clientlevel
branch
from
January 24, 2024 07:26
3e6250e
to
e5bdf08
Compare
seelderr
force-pushed
the
MC_1.20_neoforge_clientlevel
branch
from
January 24, 2024 07:31
e5bdf08
to
1ffa885
Compare
…HeightAccessor in MixinPlayerRespawnLogic
NotStirred
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.