-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminology #1774
base: main
Are you sure you want to change the base?
Terminology #1774
Conversation
Yay on the 'log into' => 'log in to'! |
'error_invalid_attribute_value' => 'Error - Attribute value not allowed', | ||
'error_invalid_attribute_value_desc' => '%idpName% sends a value for attribute %attributeName% ("%attributeValue%") which is not allowed for this %organisationNoun%. Therefore you cannot log in. Only %idpName% can resolve this. Please contact the service desk of %idpName% to fix this problem.', | ||
'error_invalid_attribute_value_desc_no_idp_name' => 'Your %organisationNoun% sends a value for attribute %attributeName% ("%attributeValue%") which is not allowed for this %organisationNoun%. Therefore you cannot log in. Only your %organisationNoun% can resolve this. Please contact the service desk of your own %organisationNoun% to fix this problem.', | ||
'error_received_error_status_code' => 'Error - Identity Provider error', | ||
'error_received_error_status_code_desc'=> 'Your %organisationNoun% has denied you access to this service. You will have to contact your own (IT-)service desk to see if this can be fixed.', | ||
'error_received_error_status_code_desc'=> 'Your %organisationNoun% has denied you access to this application. You will have to contact your service desk to see if this can be fixed.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here "own (IT-)" is lost in the change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That description is only used here, not for the other service desk references. It seemed superfluous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is to make clear that you do not need to email us. But contact your organization's service desk. But maybe indeed we can improve this in another PR, it's not related to this topic.
|
That's the rationale in the edu-world perhaps.. Same as This would have been a nice discussion for the OC-convention, but I suspect GovConext and KPMG also have a different audience and require this kind of flexibility |
This considers normal users, regardless of background. They know apps on their phone, and understand they can log in to that, but what a service is or what they can do with it is less clear. Feel free to make this configurable the same way as we do for %organisationNoun% of course! |
Can't we just make this configurable right now? After all, SURF wants to change this now, and I can very well understand that other users take a different view on this. It would perhaps also be a good idea to discuss this on the #openconext slack before merging? |
src/OpenConext/EngineBlockBundle/EventListener/RedirectToFeedbackPageExceptionListener.php
Outdated
Show resolved
Hide resolved
src/OpenConext/EngineBlockFunctionalTestingBundle/Features/AcsTinkering.feature
Outdated
Show resolved
Hide resolved
login -> log in (verb) service -> application
login -> log in (verb) service -> application
Co-authored-by: Thijs Kinkhorst <[email protected]>
Co-authored-by: Thijs Kinkhorst <[email protected]>
Co-authored-by: Thijs Kinkhorst <[email protected]>
Co-authored-by: Thijs Kinkhorst <[email protected]>
Co-authored-by: Thijs Kinkhorst <[email protected]>
No description provided.