Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminology #1774

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Terminology #1774

wants to merge 20 commits into from

Conversation

FlorisFokkinga
Copy link
Contributor

No description provided.

@tvdijen
Copy link
Contributor

tvdijen commented Dec 2, 2024

Yay on the 'log into' => 'log in to'!
I'm not sure if I like the 'service' => 'application' change.. You think we can make this configurable the same way as we do for %organisationNoun%?

languages/messages.en.php Outdated Show resolved Hide resolved
languages/messages.en.php Outdated Show resolved Hide resolved
languages/messages.en.php Outdated Show resolved Hide resolved
'error_invalid_attribute_value' => 'Error - Attribute value not allowed',
'error_invalid_attribute_value_desc' => '%idpName% sends a value for attribute %attributeName% ("%attributeValue%") which is not allowed for this %organisationNoun%. Therefore you cannot log in. Only %idpName% can resolve this. Please contact the service desk of %idpName% to fix this problem.',
'error_invalid_attribute_value_desc_no_idp_name' => 'Your %organisationNoun% sends a value for attribute %attributeName% ("%attributeValue%") which is not allowed for this %organisationNoun%. Therefore you cannot log in. Only your %organisationNoun% can resolve this. Please contact the service desk of your own %organisationNoun% to fix this problem.',
'error_received_error_status_code' => 'Error - Identity Provider error',
'error_received_error_status_code_desc'=> 'Your %organisationNoun% has denied you access to this service. You will have to contact your own (IT-)service desk to see if this can be fixed.',
'error_received_error_status_code_desc'=> 'Your %organisationNoun% has denied you access to this application. You will have to contact your service desk to see if this can be fixed.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here "own (IT-)" is lost in the change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That description is only used here, not for the other service desk references. It seemed superfluous.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is to make clear that you do not need to email us. But contact your organization's service desk. But maybe indeed we can improve this in another PR, it's not related to this topic.

languages/messages.nl.php Outdated Show resolved Hide resolved
languages/messages.nl.php Outdated Show resolved Hide resolved
theme/skeune/translations/messages.nl.php Show resolved Hide resolved
@FlorisFokkinga
Copy link
Contributor Author

Yay on the 'log into' => 'log in to'! I'm not sure if I like the 'service' => 'application' change.. You think we can make this configurable the same way as we do for %organisationNoun%?
The rationale is 'application' means much more to normal users than 'service' does.

@tvdijen
Copy link
Contributor

tvdijen commented Dec 4, 2024

The rationale is 'application' means much more to normal users than 'service' does.

That's the rationale in the edu-world perhaps.. Same as institution versus organisation and formal uw versus informal jouw. We have a different audience than SURF has.

This would have been a nice discussion for the OC-convention, but I suspect GovConext and KPMG also have a different audience and require this kind of flexibility

@FlorisFokkinga
Copy link
Contributor Author

The rationale is 'application' means much more to normal users than 'service' does.

That's the rationale in the edu-world perhaps.. Same as institution versus organisation and formal uw versus informal jouw. We have a different audience than SURF has.

This would have been a nice discussion for the OC-convention, but I suspect GovConext and KPMG also have a different audience and require this kind of flexibility

This considers normal users, regardless of background. They know apps on their phone, and understand they can log in to that, but what a service is or what they can do with it is less clear.
We decided on 'application' over 'app', because we suspect users might assume an app is on their phone.

Feel free to make this configurable the same way as we do for %organisationNoun% of course!

@baszoetekouw
Copy link
Member

baszoetekouw commented Dec 5, 2024

Feel free to make this configurable the same way as we do for %organisationNoun% of course!

Can't we just make this configurable right now? After all, SURF wants to change this now, and I can very well understand that other users take a different view on this.

It would perhaps also be a good idea to discuss this on the #openconext slack before merging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants