Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message on duplicate SP entityID in PUSH #1317

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

thijskh
Copy link
Member

@thijskh thijskh commented Sep 2, 2024

Make it clear where this occurs (MFA list) and mention the ID that's duplicated

Make it clear where this occurs (MFA list) and mention the ID that's duplicated
@thijskh thijskh requested a review from baszoetekouw September 2, 2024 14:55
Copy link
Member

@MKodde MKodde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes reviewing the error message much more intuitive!

@MKodde MKodde merged commit 8e9116b into main Sep 4, 2024
2 checks passed
@MKodde MKodde deleted the feature/improve-mfa-dupe-sp-error-msg branch September 5, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants