Ensure HTTP exception is thrown when API fails #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the pushConnectionsAction fails because the DoctrineMetadataPushRepository failed to save the assembled roles data. We should throw a HTTP exception. Otherwise the action would not output JSON. Resulting in a user facing error page. Which is not user friendly for a consumer Fixes: #1309
baszoetekouw
approved these changes
Aug 26, 2024
| @@ -54,7 +54,7 @@ public function authentication_is_required_for_pushing_metadata() | |||
| */ | |||
| public function only_post_requests_are_allowed_when_pushing_metadata($invalidHttpMethod) | |||
| { | |||
| $client = $client = static::createClient([], [ | |||
| $client = static::createClient([], [ | |||
There was a problem hiding this comment.
This change seems quite correct, but I'm curious why the strange construction with the double assignment was there in the first place?
There was a problem hiding this comment.
I think that was a find and replace mess-up. Of course PHP is perfectly happy to do this. 🙄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the pushConnectionsAction fails because the DoctrineMetadataPushRepository failed to save the assembled roles data. We should throw a HTTP exception. Otherwise the action would not output JSON. Resulting in a user facing error page. Which is not user friendly for a consumer
Fixes: #1309