Remove unused class #1293
Merged
Remove unused class #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdijen
added
maintenance
proposed-removal
thijskh
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this because I want to harden my PHP install by setting
allow_url_fopentofalse..I've discussed this on Slack with @thijskh and the class is not being used anywhere at all..
Thijs thought this was an old feature where it was possible to enable schema-validation on messages and/or metadata, but it no longer exists.
An alternative to this removal would be to restore the feature, but use local certs from the saml2-lib, that has all of them available for use without downloading them from anywhere remote.