Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update User's guide “convert-a-c++-program” #102

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

behoppe
Copy link
Member

@behoppe behoppe commented Jul 20, 2022

Automatically generated by Netlify CMS

@netlify
Copy link

netlify bot commented Jul 20, 2022

Deploy Preview for sage-licorice-6da44d ready!

Name Link
🔨 Latest commit 8d91f2c
🔍 Latest deploy log https://app.netlify.com/sites/sage-licorice-6da44d/deploys/632a1811c6f5bd0008498827
😎 Deploy Preview https://deploy-preview-102--sage-licorice-6da44d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@behoppe behoppe force-pushed the cms/users-guide/convert-a-c++-program branch from 395e1d5 to 23c931a Compare July 20, 2022 19:00
@behoppe behoppe force-pushed the cms/users-guide/convert-a-c++-program branch from d4be2e3 to c770144 Compare July 20, 2022 19:40
@behoppe behoppe linked an issue Jul 29, 2022 that may be closed by this pull request
@behoppe behoppe added this to the Version 1.0 milestone Jul 30, 2022
@behoppe
Copy link
Member Author

behoppe commented Aug 9, 2022

Hi @timkaler I have implemented a way to display attribution to Intel and Cilk Arts. If you think this article should credit them, then could you please find the new switch in the CMS editor ("provide attribution to Intel and Cilk Arts") or manually add attribution: true to the front matter. If you set the field to true, then the attribution still won't actually display until this PR is merged with the main branch. (A little more info is at #62.) Thank you.

@behoppe
Copy link
Member Author

behoppe commented Aug 18, 2022

Hi @timkaler would it be OK with you if I edited this article? Based on feedback we heard from Charles (e.g., use cilk_scope and make it more conversational) I could go through the whole thing, and then maybe we could ask Alex or Charles to give it a final review before publishing.

There is a lot of good content in here, so I hope we can publish it soon.

@behoppe behoppe force-pushed the cms/users-guide/convert-a-c++-program branch from c770144 to fd47847 Compare September 16, 2022 18:36
@behoppe behoppe requested a review from ailiop September 20, 2022 19:54
@behoppe
Copy link
Member Author

behoppe commented Sep 20, 2022

Thanks @timkaler for this excellent draft. I reviewed and made small stylistic changes along a few lines listed below.

I think this is good to go after we make sure that our qsort.cpp example is consistent across this article and the Cilkscale user's guide. This includes inline code, related discussion points, and the Cilkscale plots. @ailiop would you like to review these two with that in mind?

My sylistic edits:

  • Less formal (more "conversational")
  • More consistent with the Cilkscale user's guide
  • Adding a "Discussion" section, which holds the part about improving performance of partition

@behoppe
Copy link
Member Author

behoppe commented Apr 5, 2023

@ailiop and @timkaler could one of you please review this to make sure it's ready for publication? Thank you. (I edited it many months ago and it fell through the cracks.)
https://deploy-preview-102--sage-licorice-6da44d.netlify.app/doc/users-guide/convert-a-c-program/

@behoppe
Copy link
Member Author

behoppe commented Feb 7, 2024

@timkaler what do you recommend we do with this PR (which came up during last week's meeting)? The PR has a lot of good content that is not on the published website. There are some outstanding issues mentioned in the previous comments (from April 2023 and Sept 2022) about aligning this article with the Cilkscale user's guide, because they both rely heavily on quicksort, and probably it would be best for them to share the same quicksort. Would you like to look into that, or recommend someone, or shall we publish this content as-is? Thanks for helping with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/doc/users-guide/convert-a-c-program/
2 participants