-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Range-based cilk_for #55
Open
arvid220u
wants to merge
65
commits into
OpenCilk:release/10.x
Choose a base branch
from
arvid220u:arvid/cilkforrange
base: release/10.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix crash for aggregate types
* add range loop test * add * frewrite-includes * fix range loop test * addworkingalmostrangelooptest * address some warnings * add more expected warnings and notes * ignore notes * cilkforrange ir * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * add more isinvalid checks * add more errors * add more errors * add more errors * add more errors * add more errors * add more errors * idk * idk * idk * idk * idk * vector mock * better vector mock * dont actually malloc * fix? * fix? * fix? * fix? * fix? * rangelooptest all mocked out * pragma allowed for forrange too * pragma cilk allowed too * fix ir * ir fix * ir fix * fix ir * fix ir * bug * bug * regexify * regexify * more tests * fix name mangling * fix test * auto test * name mangling * final test * name mangling * clang format Co-authored-by: <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implements a range-based cilk_for syntax supporting containers with random access iterators.
For example, this PR adds support for syntax on the form:
Previously, you had to do:
Implementation
We introduce a new AST type,
CilkForRangeStmt
, taking inspiration from bothCilkForStmt
andCXXForRangeStmt
.The
CilkForRangeStmt
internally stores aCXXForRangeStmt
, and lets theCXXForRangeStmt
handle the parsing of the for loop. It then outputs IR similar to aCilkForStmt
. The loop control differs from what one might expect: instead of having the loop variable be an iterator going fromcontainer.begin()
tocontainer.end()
as in a normal for range loop, we emit a loop index of typedifference_type
going from0
tocontainer.end() - container.begin()
. This makes it possible for the Tapir loop pass to transform the loop into a divide and conquer.Testing
clang/test/Cilk/rangelooptest.cpp
.clang/test/Cilk/cilkforrange-ir.cpp
.-fsanitize=cilk
(Cilksan), reporting 0 determinancy races.O0
, and having no observable difference on any higher optimization levels.