Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lowering of tapir.runtime.start and tapir.runtime.end intrinsics #274

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Fix lowering of tapir.runtime.start and tapir.runtime.end intrinsics #274

merged 3 commits into from
Sep 16, 2024

Conversation

neboat
Copy link
Collaborator

@neboat neboat commented Sep 9, 2024

This PR fixes some bugs in lowering tapir.runtime.start and tapir.runtime.end intrinsics, including:

  • A misoptimization that would lead to invalid IR
  • Redundant handling of these intrinsics during Tapir lowering, which would lead to bitcode-ABI methods getting called multiple times. In this case, the parallel code would exhibit runtime assertion failures when run.

@neboat
[Verifier] Add verification check that tapir.runtime.start intrinsics…
45f5440 
… have associated tapir.runtime.end calls that use them.
@neboat
[TaskSimplify] Prevent tapir.runtime.start calls from getting hoisted…
5e9e645 
… out of taskframes. Allowing such hoisting can cause Tapir lowering to subsequently crash.
@neboat
[OpenCilkABI] Fix lowering to make sure a tapir.runtime instrinsic re…
2a3a6f0 
…sults in just one call to a bitcode-ABI function.
@neboat neboat merged commit 876a661 into OpenCilk:dev/18.x Sep 16, 2024
7 checks passed
@neboat neboat deleted the dev/18.x-tapir-runtime-lowering branch November 23, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@neboat